-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Remove checking region/zone and service name from googlecloud #18398
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once comment about the nil check you added.
What does this PR do?
This PR is to remove validations for region/zone/service name in order for
stackdriver
metricset to work for wider services.Why is it important?
service
is only used to check when adding metadata and this is only available forcompute
metricset right now.region/zone
is not required for makingListTimeSeriesRequest
API.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Enable googlecloud in Metricbeat
./metricbeat modules enable googlecloud
Modify modules.d/googlecloud.yml to use stackdriver metricset to collect logging metrics:
You should see metrics in Kibana like:
googlecloud.stackdriver.byte_count.value
andgooglecloud.stackdriver.billing.bytes_ingested.value
Change modules.d/googlecloud.yml to collect compute metrics and also should work:
Related issues