Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18431 to 7.x: Remove the injectPreferV2Template decorator. #18463

Merged
merged 1 commit into from
May 13, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #18431 to 7.x branch. Original message:

What does this PR do?

Removes the injectPreferV2Template as its no longer needed in 7.8 because of elastic/elasticsearch#56546.

Why is it important?

The parameters no longer exists so it must be removed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 12, 2020
@blakerouse blakerouse changed the title Remove the injectPreferV2Template decorator. (#18431) Cherry-pick #18431 to 7.x: Remove the injectPreferV2Template decorator. May 12, 2020
@blakerouse
Copy link
Contributor Author

This actually needs #18464 to be merged first, then this one can follow.

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

@ruflin ruflin requested a review from michalpristas May 13, 2020 06:54
@blakerouse blakerouse force-pushed the revert-prefer-v2-7.x branch from 5136795 to bf3fb39 Compare May 13, 2020 14:59
@blakerouse
Copy link
Contributor Author

#18464 has been merged, now this is ready for review and landing into 7.x.

@blakerouse blakerouse merged commit 4345e93 into elastic:7.x May 13, 2020
@blakerouse blakerouse deleted the revert-prefer-v2-7.x branch May 13, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants