-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libbeat] Remove global loggers from plugin and mock #18552
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we're trying to have the logger name match the literal go library they're in. Try logp.NewLogger("mock")
and so on.
@fearful-symmetry Thanks! Good to know, I just changed the logger name to |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
* [libbeat] Remove global loggers from plugin/cli
This PR is to remove global loggers for libbeat/plugin/cli.
Please see #15699 for the meta-issue and more details.