Quick Cleanup #1857
Merged
Quick Cleanup #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I quick went through the TODO's and fixed the easy ones or removed unnecessary ones. * Remove debug log messages as it spams the log file. This happens every time an event or update is published
| @@ -164,9 +164,6 @@ def test_exclude_files(self): | |||
| lambda: self.output_has(lines=1), | |||
| max_timeout=15) | |||
|
|
|||
| # TODO: Find better solution when filebeat did crawl the file | |||
| # Idea: Special flag to filebeat so that filebeat is only doing and | |||
| # crawl and then finishes | |||
| filebeat.check_kill_and_wait() | |||
There was a problem hiding this comment.
have we found a better solution? If not, let's move comment to def check_kill_and_wait.
There was a problem hiding this comment.
@urso not yet, but we had the comment in at least 10 times. I still left it in once so we remember.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quick went through the TODO's and fixed the easy ones or removed unnecessary ones.