Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] speed builds for module specific changes #18592

Merged
merged 10 commits into from
May 20, 2020
Merged

[ci] speed builds for module specific changes #18592

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4bd79d8
ci: speed builds for module specific changes
v1v May 15, 2020
f22c835
chore: for testing purposes
v1v May 15, 2020
4bd8cdc
fix: typo
v1v May 16, 2020
bf830ad
Merge remote-tracking branch 'upstream/master' into feature/ci-for-si…
v1v May 16, 2020
52ce264
Revert "chore: for testing purposes"
v1v May 16, 2020
6b65f05
chore: for testing purposes
v1v May 16, 2020
a629c28
Revert "chore: for testing purposes"
v1v May 18, 2020
323bcf7
ci: rollback test changes
v1v May 18, 2020
81cf4b4
ci: use the new step library
v1v May 18, 2020
eb9e44e
regex: to exclude what's not a module
v1v May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,11 @@ def loadConfigEnvVars(){

// Skip all the stages for changes only related to the documentation
env.ONLY_DOCS = isDocChangedOnly()

// Run the ITs by running only if the changeset affects a specific module.
// For such, it's required to look for changes under the module folder and exclude anything else
// such as ascidoc and png files.
env.MODULE = getGitMatchingGroup(pattern: '[a-z0-9]+beat\\/module\\/([^\\/]+)\\/.*', exclude: '^(((?!\\/module\\/).)*$|.*\\.asciidoc|.*\\.png)')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're now excluding anything that's not under /module/, do we also need the .*\.asciidoc and .*\.png patterns in the exclude list?

Copy link
Member Author

@v1v v1v May 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do, otherwise all those PRs that change the top-level CHANGELOG.next.asciidoc will not match the pattern, besides, the exclude does include the png files similar to the pattern that it is used for whether the PR is only related to docs changes. We could potentially remove the png if required, although I don't know all the cases, but the asciidoc is needed.

For instance:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lets keep this for now and optimize later.

}

/**
Expand Down