Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18654 to 7.x: Update golang.org/x/crypto #18670

Merged
merged 1 commit into from
May 21, 2020
Merged

Cherry-pick #18654 to 7.x: Update golang.org/x/crypto #18670

merged 1 commit into from
May 21, 2020

Conversation

adriansr
Copy link
Contributor

Cherry-pick of PR #18654 to 7.x branch. Original message:

This addresses a problem with golang.org/x/crypto/ssh/terminal used as secure input under Windows (golang/go#36609).

Fixes #18649

@adriansr
Update golang.org/x/crypto (elastic#18654)
ea9c6e9 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649

(cherry picked from commit 2c90b6a)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
kaiyan-sheng
kaiyan-sheng approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Adrian Serrano, Replayed I can't install packetbeat #1]

  • Start Time: 2020-05-21T10:04:41.145+0000

  • Duration: 71 min 59 sec (4258614)

Test stats 🧪

Test Results
Failed 0
Passed 6615
Skipped 1053
Total 7668

Steps errors

Expand to view the steps failures

  • Name: Install Go 1.13.10

    • Description: .ci/scripts/install-go.sh

    • Result: FAILURE

    • Duration: 1 min 47 sec

    • Start Time: 2020-05-21T10:28:16.446+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-21T10:43:46.965+0000

    • log

@adriansr adriansr merged commit 12ef93c into elastic:7.x May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @kaiyan-sheng