[Filebeat] add multi_fields in aws cloudtrail fileset #19021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A keyword representation of the following fields was stored. Adding text multi_fields so it can be searched more easily. - request_parameters - response_elements - additional_eventdata - service_event_details Closes elastic#18866
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
andrewkroh
previously approved these changes
Jun 10, 2020
| @@ -42,6 +42,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| * iptables {pull}18756[18756] | |||
| * Checkpoint {pull}18754[18754] | |||
| - Preserve case of http.request.method. ECS prior to 1.6 specified normalizing to lowercase, which lost information. Affects filesets: apache/access, elasticsearch/audit, iis/access, iis/error, nginx/access, nginx/ingress_controller, aws/elb, suricata/eve, zeek/http. {issue}18154[18154] {pull}18359[18359] | |||
| - In aws cloudtrail fileset add multi_fields for request_parameters, response_elements, additional_eventdata & service_event_details. {issue}18866[18866] {pull}XXX[XXX] | |||
There was a problem hiding this comment.
Suggested change
| - In aws cloudtrail fileset add multi_fields for request_parameters, response_elements, additional_eventdata & service_event_details. {issue}18866[18866] {pull}XXX[XXX] | |
| - In aws cloudtrail fileset add multi_fields for request_parameters, response_elements, additional_eventdata & service_event_details. {issue}18866[18866] {pull}19021[19021] |
andrewkroh
reviewed
Jun 10, 2020
| - name: response_elements | ||
| type: keyword | ||
| description: >- | ||
| The response element for actions that make changes (create, | ||
| update, or delete actions). | ||
| multi_fields: |
There was a problem hiding this comment.
Does this work with the proposed changes in #19020? It seems like they conflict because response_elements will no longer be string so it cannot be indexed at text.
andrewkroh
dismissed
their stale review
Pending discussion of #19020 + this change.
andrewkroh
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A keyword representation of the following fields was stored. Adding
text multi_fields so it can be searched more easily.
What does this PR do?
A string representation of the following fields was stored and indexed
as keyword. Adding a text multi_fields so it can be searched more easily.
Why is it important?
Adding multi_fields makes searching easier and avoids mapping explosion
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues