Fix k8s scheduler compatibility issue #19699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
botelastic
bot
added
the
needs_team
Signed-off-by: chrismark <[email protected]>
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
zube
bot
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
zube
bot
added
[zube]: In Review
[zube]: Inbox
and removed
[zube]: Inbox
[zube]: In Review
labels
jsoriano
reviewed
Jul 7, 2020
ChrsMark
changed the title
Signed-off-by: chrismark <[email protected]>
exekias
approved these changes
Jul 7, 2020
exekias
added
the
needs_backport
|
thank you for fixing this @ChrsMark ! |
6 tasks
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Jul 8, 2020
(cherry picked from commit aa60a58)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Jul 8, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces
OpSetSuffixin order to solve a compatibility issue in Kubernetes Scheduler metricset.In older version of k8s the Prometheus metric
scheduler_pod_preemption_victimswas a Gauge but recently they changed itto a Histogram. Until now we have been mapping this Gauge metric to
scheduling.pod.preemption.victims.countfield. This makes it impossible for the module to parse Prometheus metrics from newer versions of Scheduler where this filed is a Histogram. With this PROpSetSuffixcan try to check if the value of this metric is numeric and extend it withcountersuffix otherwise it is of Histogram type and we do nothing. This makesscheduling.pod.preemption.victims.countfiled to be actually numeric in all cases since Histograms create this filed by default and when it is a Gauge we leverage theOpSetSuffixto do the mapping appropriately.Why is it important?
In order to preserve compatibility with old and new versions of Prometheus metrics exported by Kubernetes Scheduler.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues