Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jjbb] Use GitHub app token #19852

Merged
merged 1 commit into from
Jul 14, 2020
Merged

[jjbb] Use GitHub app token #19852

merged 1 commit into from
Jul 14, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 13, 2020 •
edited
Loading

What does this PR do?

A new GH app has been created to help with the number of API Calls done when using the Jenkins Multibranch pipeline

Why is it important?

  • From 5k quota to up to 3 times more.
  • Changes have being done in the UI already.
Started
[Mon Jul 13 16:12:10 UTC 2020] Starting branch indexing...
Connecting to https://api.github.com using 72677/****** (Jenkins - beats-ci)
Examining elastic/beats

Used to be

image

Now

image

For further details please refers to:

@v1v v1v self-assigned this Jul 13, 2020
@v1v v1v added the automation label Jul 13, 2020
@v1v v1v requested a review from a team July 13, 2020 16:38
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@v1v v1v requested a review from leathekd July 13, 2020 16:40
@v1v v1v added the Team:Automation Label for the Observability productivity team label Jul 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@v1v v1v marked this pull request as ready for review July 13, 2020 16:40
v1v
v1v commented Jul 13, 2020
View reviewed changes
.ci/jobs/beats-windows-mbp.yml
@@ -15,10 +15,10 @@
discover-tags: false
# Run MBP for the master branch and PRs
head-filter-regex: '(master|PR-.*)'
notification-context: 'beats-ci'
notification-context: 'beats-ci/windows'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a dummy change to help with a different GH check for this particular MBP

@mdelapenya
Copy link
Contributor

@v1v should we update other projects running under beats-ci, like the e2e-testing one?

@v1v
Copy link
Member Author

v1v commented Jul 14, 2020

should we update other projects running under beats-ci, like the e2e-testing one?

Yes, although they are not urgent at all, so far, the jjbb automation in the infra side has been disabled for the beats project only, this will help to put back the automation in place.

@mdelapenya mdelapenya mentioned this pull request Jul 14, 2020
Merged
@v1v v1v merged commit 72cc711 into elastic:master Jul 14, 2020
@v1v v1v deleted the feature/jjbb-github-app branch July 14, 2020 13:26
This was referenced Aug 11, 2020
Merged
Merged
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@v1v @melchiormoulin
[jjbb] Use GitHub app token (elastic#19852)
11492c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@leathekd leathekd Awaiting requested review from leathekd

Assignees

@v1v v1v

Labels
automation Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @mdelapenya @kuisathaverat