Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check readStringAndTrimDelimiter error against EOF #20041

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Check readStringAndTrimDelimiter error against EOF #20041

merged 1 commit into from
Jul 20, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is continuing with #19972 and fix error checking after readStringAndTrimDelimiter function.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 17, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Jul 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20041 opened]

  • Start Time: 2020-07-17T23:07:58.910+0000

  • Duration: 51 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

@kaiyan-sheng kaiyan-sheng merged commit 3932eaa into elastic:master Jul 20, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_s3 branch July 20, 2020 13:41
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Jul 20, 2020
kaiyan-sheng added a commit that referenced this pull request Jul 21, 2020
@kaiyan-sheng
Cherry-pick #19972 to 7.9: [Filebeat] remove delimiter \n from log li…
57bf5f8 
…ne in s3 input (#20064)

* [Filebeat] remove delimiter \n from log line in s3 input (#19972)

* remove delimiter \n from log line in s3 input

(cherry picked from commit 9ca82b4)

* backport #20041
kaiyan-sheng added a commit that referenced this pull request Jul 22, 2020
@kaiyan-sheng
Cherry-pick #19972 to 7.x: [Filebeat] remove delimiter \n from log li…
6e50a4c 
…ne in s3 input (#20063)

* [Filebeat] remove delimiter \n from log line in s3 input (#19972)

* remove delimiter \n from log line in s3 input

(cherry picked from commit 9ca82b4)

* backport #20041
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kaiyan-sheng @melchiormoulin
Check readStringAndTrimDelimiter error against EOF (elastic#20041)
dac9e4e
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#19972 to 7.9: [Filebeat] remove delimiter \n from…
bb8216d 
… log line in s3 input (elastic#20064)

* [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972)

* remove delimiter \n from log line in s3 input

(cherry picked from commit 08a9f95)

* backport elastic#20041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @exekias