Disable the option of running setup --machine-learning on its own #20241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kvch
added
[zube]: In Review
needs_backport
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
jenkins run tests |
kvch
force-pushed
the
fix-filebeat-ml-loading
branch
from
de74156 to
ddc688f
Compare
urso
approved these changes
Jul 28, 2020
Merged
3 tasks
kvch
added
v7.9.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 28, 2020
…astic#20241) This PR disables running `setup --machine-learning` on its own. From now on `setup --machine-learning --dashboards` has to be specified to enable ML jobs. ML jobs require an index template pattern in Kibana. If it is not configured, loading the jobs fails. However, loading this asset is done by the dashboards step of setup. Loading index template patterns are too tightly coupled with Kibana and dashboards and it needs refactoring. As this code is way too complex and going to be removed soon, I opted for a workaround instead of a fix. Closes elastic#19964 Closes elastic#12998 Closes elastic#20022 (cherry picked from commit ca7ce29)
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kvch
added a commit
that referenced
this pull request
Jul 29, 2020
…0241) (#20266) This PR disables running `setup --machine-learning` on its own. From now on `setup --machine-learning --dashboards` has to be specified to enable ML jobs. ML jobs require an index template pattern in Kibana. If it is not configured, loading the jobs fails. However, loading this asset is done by the dashboards step of setup. Loading index template patterns are too tightly coupled with Kibana and dashboards and it needs refactoring. As this code is way too complex and going to be removed soon, I opted for a workaround instead of a fix. Closes #19964 Closes #12998 Closes #20022 (cherry picked from commit ca7ce29)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#20241) (elastic#20266) This PR disables running `setup --machine-learning` on its own. From now on `setup --machine-learning --dashboards` has to be specified to enable ML jobs. ML jobs require an index template pattern in Kibana. If it is not configured, loading the jobs fails. However, loading this asset is done by the dashboards step of setup. Loading index template patterns are too tightly coupled with Kibana and dashboards and it needs refactoring. As this code is way too complex and going to be removed soon, I opted for a workaround instead of a fix. Closes elastic#19964 Closes elastic#12998 Closes elastic#20022 (cherry picked from commit 4ebf884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables running
setup --machine-learningon its own. From now onsetup --machine-learning --dashboardshas to be specified to enable ML jobs.Why is it important?
ML jobs require an index template pattern in Kibana. If it is not configured, loading the jobs fails. However, loading this asset is done by the dashboards step of setup.
Loading index template patterns are too tightly coupled with Kibana and dashboards and it needs refactoring. As this code is way too complex and going to be removed soon, I opted for a workaround instead of a fix.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #19964
Closes #12998
Closes #20022