Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IsConnected from ProtocolClient interface #2030

Merged
merged 2 commits into from
Jul 13, 2016
Merged

Remove IsConnected from ProtocolClient interface #2030

merged 2 commits into from
Jul 13, 2016

Conversation

urso
Copy link

@urso urso commented Jul 13, 2016

  • Always close connections on failure and enforce reconnect.
  • IsConnected flag gone from elasticsearch output (no more error if template already loaded).

Closes: #1997

@ruflin
Copy link
Contributor

ruflin commented Jul 13, 2016

LGTM

@tsg tsg merged commit 6177714 into elastic:master Jul 13, 2016
@tsg
Copy link
Contributor

tsg commented Jul 13, 2016

LGTM, and can confirm that this fixes #1997.

@urso urso deleted the issue/1997-connection-closing branch February 19, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch output reconnects on 4xx response codes
3 participants
@urso @ruflin @tsg