Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest. Manager] Move from datastream to data_stream #20439

Merged
merged 3 commits into from
Aug 5, 2020
Merged

[Ingest. Manager] Move from datastream to data_stream #20439

merged 3 commits into from
Aug 5, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Changes datastream to data_stream

Why is it important?

Preventing potential breaking change in next release

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added review Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels Aug 5, 2020
@michalpristas michalpristas self-assigned this Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 5, 2020
@michalpristas michalpristas changed the title updated spelling [Ingest. Manager] Move from datastream to data_stream Aug 5, 2020
@ruflin
Copy link
Contributor

ruflin commented Aug 5, 2020

@michalpristas As part of this PR, also the shipping of dataset.* fields should be removed. Lets also make sure this gets "forward" ported to master and 7.x quickly.

@michalpristas
Copy link
Contributor Author

@ruflin i have 2 PRs depending on which way we will take. this one is a simple change
this one #20420 is a complete removal

ruflin
ruflin approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this change in first before we do config.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20439 updated]

  • Start Time: 2020-08-05T07:57:43.625+0000

  • Duration: 36 min 4 sec

@michalpristas michalpristas merged commit 204b744 into elastic:7.9 Aug 5, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@michalpristas
[Ingest. Manager] Move from datastream to data_stream (elastic#20439
ae89667 
)

[Ingest. Manager] Move from `datastream` to `data_stream` (elastic#20439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
Ingest Management:beta1 Group issues for ingest management beta1 review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ruflin