Cherry-pick #20435 to 7.x: [Filebeat][http_endpoint input] Adds support for custom auth header names and secret #20519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
CHANGELOG.next.asciidoc
Outdated
| @@ -586,6 +586,10 @@ field. You can revert this change by configuring tags for the module and omittin | |||
| - Add experimental dataset zscaler/zia for Zscaler Internet Access logs {pull}19713[19713] | |||
| - Add event.ingested for CrowdStrike module {pull}20138[20138] | |||
| - Add support for additional fields and FirewallMatchEvent type events in CrowdStrike module {pull}20138[20138] | |||
| - Add event.ingested for Suricata module {pull}20220[20220] | |||
There was a problem hiding this comment.
extra changelog entries
kvch
approved these changes
Aug 12, 2020
…ames and secret (elastic#20435) (cherry picked from commit d4fb2bc)
urso
force-pushed
the
backport_20435_7.x
branch
from
bd13b8a to
03dd073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20435 to 7.x branch. Original message:
What does this PR do?
Certain webhooks offers functionality to add a custom header and defined secret to each request to identify the source. This PR adds the possibility to configure the header name and secret that needs to be confirmed for every request, similar but not the same as basic auth.
Why is it important?
Required for certain modules like Zoom #20414
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Added nosetest for wrong configuration option, ensuring that anything not matching header+secret is dropped and that a successful match allows the request with the correct responses.
Tested with: