Build Heartbeat for Agent from the OSS directory #20561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
jsoriano
added
Agent
Heartbeat
Team:Integrations
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/uptime (Team:Uptime) |
|
/packaging |
1 similar comment
|
/packaging |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This reverts commit d036955.
jsoriano
force-pushed
the
heartbeat-agent-build-directory
branch
from
8068033 to
cd7c245
Compare
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
/packaging |
|
@jsoriano There is an open PR from blake which should fix some tests: #20498 But would this solve the packaging issue? There is also a PR from @andrewvc to fix things: #20563 Also adding @andrewkroh here. I think we should have a quick chat today on how to get CI back to green quickly. |
|
CI should be fixed after #20566, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Heartbeat packages both for OSS and X-Pack are built using the magefile in the OSS directory. Use this magefile also when building heartbeat for the Elastic Agent.
It also reverts #20549 as produces some issues when building packages.
Why is it important?
To use the same magefile when building Heartbeat for Agent, and for the rest of distributions.
Related issues