Update golang text dependency #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
ruflin
force-pushed
the
golang-test-update
branch
2 times, most recently
from
47b5ca5 to
12de846
Compare
|
|
||
| // This can happen if something goes wrong during decoding | ||
| if len(buf) == 0 { | ||
| logp.Debug("wwer", "empty buffer, continue") |
ruflin
force-pushed
the
golang-test-update
branch
from
19cbae1 to
1dded17
Compare
|
@urso I now cleaned up the PR and added comments. I also updated to the most recent version. Please have a look. |
| decoder func() transform.Transformer | ||
| encoder func() transform.Transformer | ||
| } | ||
| // mixed incoder is a copy of encoding.Replacement |
ruflin
force-pushed
the
golang-test-update
branch
from
e9d100d to
df772ab
Compare
|
@urso New version with review changes pushed. |
|
LGTM |
* Improve error logging in line reader
ruflin
force-pushed
the
golang-test-update
branch
from
df772ab to
05b0917
Compare
urso
added
review
and removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.