Fix state removal and sending empty lines #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
= State Removal With a very low scan_frequency it could potentially happen, that a state of a finished harvester was overwritten by the prospector which lead to the problem, that the state was never set to Finished. This is now fixed in that the prospector only sends a state when the state is set to Finished. = Sending empty lines Empty lines were still sent as the byte check was set to 0 and with the newline char it was always at least 1. The tests passed because filebeat was shutdown before the last line was written. Tests were now improved to tests both cases.
ruflin
force-pushed
the
fix-flaky-filebeat-test
branch
from
3d37cf5 to
4d3ee0e
Compare
ruflin
changed the title
ruflin
added
review
and removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State Removal
With a very low scan_frequency it could potentially happen, that a state of a finished harvester was overwritten by the prospector which lead to the problem, that the state was never set to Finished. This is now fixed in that the prospector only sends a state when the state is set to Finished.
Sending empty lines
Empty lines were still sent as the byte check was set to 0 and with the newline char it was always at least 1. The tests passed because filebeat was shutdown before the last line was written. Tests were now improved to tests both cases.
Example failed build: http://build-eu-00.elastic.co/job/Beats-PR/2577/