-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #21457 to 7.x: Remove nil-zero metrics and linux-exclusive metrics from Metricbeat #21597
Cherry-pick #21457 to 7.x: Remove nil-zero metrics and linux-exclusive metrics from Metricbeat #21597
Conversation
…lastic#21457) * refactor metricbeat to remove nil-zero metrics and linux-exclusive metrics * update xpack docs * fix non-linux diskstat builds * fix linux test builds * fix python tests * move windows files for disk performance * properly fix test_drop_fields * try to fix different system test * mage fmt * fix windows filesystem tests * fix platform test * add changelog (cherry picked from commit aed4831)
Pinging @elastic/integrations (Team:Integrations) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Cherry-pick of PR #21457 to 7.x branch. Original message:
What does this PR do?
This PR has two main parts:
0
instead of nothing) for a given metric on a given OS, add some conditional logic so we don't report it.Also note, I'm actively working on this PR, so it might be a tad rough right now, but I want eyes on it.
Where do we go from here?
IsAgent
logic we have to prevent breaking field changes in metricbeat.Open Questions
system
now have their own module inlinux
. After this PR, we'll add these new linux modules to the Linux integration within fleet. From the perspective of metricbeat, we're now reporting identical data in two places: in the default system module, and in new metricsets within the linux integration. Is this the best route? Is there a better way to handle metrics we're trying to relocate?Why is it important?
This is the result of a lot of work between @mukeshelastic and I, with two goals:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
mage package
to generate a system-specific build object. You can use thePLATFORMS
environment variable to constrain to a given OS/arch pair likelinux/amd64
.cpu
,memory
,diskio
,process
,filesystem
,fsstat
fields haven't changed relative todata.json
memory
andiostat
linux metricsets for all the expected fields.cpu
,memory
,diskio
,process
,filesystem
, andfsstat
metricsets to make sure all the fields reported asIncorrect 0 value?
on the spreadsheet are no longer reported.IsAgent
constraints are working and we're not reporting additional data.