Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21599 to 7.10: [Elastic Agent] Reload fleet.kibana.hosts from policy change #21666

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Cherry-pick #21599 to 7.10: [Elastic Agent] Reload fleet.kibana.hosts from policy change #21666

merged 1 commit into from
Oct 8, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #21599 to 7.10 branch. Original message:

What does this PR do?

When a policy change is sent to the Elastic Agent it will now read the fleet.kibana.hosts values and if its different then the current running values it will re-create the Kibana client with the new hosts list and update the fleet.yml to include the new information.

Why is it important?

Allows an Agent to be updated with the new endpoints to contact back to Kibana, including multiple hosts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse
[Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic…
3c5c911 
…#21599)

* Update the connected client for kibana from policy change.

* Fix vet.

* Add changelog.

* Add protocol compare.

* Rollback protocol and hosts on failure.

(cherry picked from commit 1891717)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 7, 2020
@blakerouse blakerouse self-assigned this Oct 7, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21666 opened]

  • Start Time: 2020-10-07T23:55:17.871+0000

  • Duration: 37 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 1386
Skipped 4
Total 1390

michalpristas
michalpristas approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport look legit ✅

@blakerouse blakerouse merged commit 47b32e9 into elastic:7.10 Oct 8, 2020
@blakerouse blakerouse deleted the backport_21599_7.10 branch October 8, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @michalpristas