Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21694 to 7.x: [Elastic Agent] Remove the service installer scripts from packaging #21808

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #21694 to 7.x branch. Original message:

What does this PR do?

Removes the install-service.ps1 and uninstall-service.ps1 from the Windows .zip package, as the .\elastic-agent install should be used instead.

Why is it important?

To align of the usage of the install command on Windows.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…lastic#21694)

* Remove the service installer scripts from packaging.

* Add changelog.

(cherry picked from commit e38d417)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2020
@blakerouse blakerouse self-assigned this Oct 14, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21808 opened]

  • Start Time: 2020-10-14T15:17:04.268+0000

  • Duration: 99 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 16324
Skipped 1367
Total 17691

@blakerouse blakerouse merged commit fa3ac1c into elastic:7.x Oct 14, 2020
@blakerouse blakerouse deleted the backport_21694_7.x branch October 14, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants