Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21776 to 7.x: Add cloud.account.id into add_cloud_metadata for gcp #21868

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Cherry-pick #21776 to 7.x: Add cloud.account.id into add_cloud_metadata for gcp #21868

merged 1 commit into from
Oct 19, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 15, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21776 to 7.x branch. Original message:

What does this PR do?

Add cloud.account.id into add_cloud_metadata processor for GCP.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 15, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 15, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21868 opened]

  • Start Time: 2020-10-15T20:49:55.720+0000

  • Duration: 83 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 16331
Skipped 1368
Total 17699

narph
narph approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit f556a8a into elastic:7.x Oct 19, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_21776_7.x branch October 19, 2020 13:01
@zube zube bot removed the [zube]: Done label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @narph