-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove data.json registry info #22165
Conversation
This pull request doesn't have a |
We got a new setting named New-style inputs that use the registry did get a new setting named |
@urso I'm trying to figure out the best way to document the new settings so that users will know whether the settings apply to their config. Saying "new-style input" isn't going to help users, and I'm pretty sure we don't want to list all the inputs that support the new settings. Is there some sway of describing these new-style inputs so that it will be clear to users whether the new settings are applicable? |
Unfortunately not. It's an implementation detail. Almost all inputs that store state between restarts have switched to the new API. The only exceptions are the log and docker/container inputs I think. |
@dedemorton do we want to merge this PR as is and create a follow up issue? |
@urso Yes, but you should create the follow-up issue because I don't think I can describe this. |
Follow up issue: #22513 (I hope the issue is a little more clear) |
The behavior of the Filebeat registry changed in 7.9. The registry no longer uses a file called data.json.
I've removed the places where we mention the file, but someone on the dev team needs to confirm that the registry settings have not changed.