Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data.json registry info #22165

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

dedemorton
Copy link
Contributor

The behavior of the Filebeat registry changed in 7.9. The registry no longer uses a file called data.json.

I've removed the places where we mention the file, but someone on the dev team needs to confirm that the registry settings have not changed.

@dedemorton dedemorton added docs Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. needs_reviewer PR needs to be assigned a reviewer labels Oct 26, 2020
@dedemorton dedemorton requested a review from urso October 26, 2020 18:10
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2020
@botelastic
Copy link

botelastic bot commented Oct 26, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22165 opened]

  • Start Time: 2020-10-26T18:11:06.715+0000

  • Duration: 24 min 33 sec

@dedemorton dedemorton closed this Oct 26, 2020
@dedemorton dedemorton reopened this Oct 26, 2020
@urso
Copy link

urso commented Oct 26, 2020

We got a new setting named filebeat.registr.clean_interval. The setting does not affect the log input or the container input. But new inputs like o365audit make us of it: The setting configures the interval the inputs check for stale outdated state entries.

New-style inputs that use the registry did get a new setting named clean_timeout. So far o365audit and httpjson are the only once that make use of it (winlog input is not documented and journald is excluded by the build). The clean_timeout setting configures a source time-to-live (TTL). If the source is not collected and latest update timestamp + clean_timeout > now and entry is assumed to be stale and will be removed by the next gc-run whose interval is configured by the filebeat.registry.clean_interval setting.

@dedemorton
Copy link
Contributor Author

dedemorton commented Oct 27, 2020

@urso I'm trying to figure out the best way to document the new settings so that users will know whether the settings apply to their config. Saying "new-style input" isn't going to help users, and I'm pretty sure we don't want to list all the inputs that support the new settings. Is there some sway of describing these new-style inputs so that it will be clear to users whether the new settings are applicable?

@urso
Copy link

urso commented Oct 28, 2020

Is there some sway of describing these new-style inputs so that it will be clear to users whether the new settings are applicable?

Unfortunately not. It's an implementation detail. Almost all inputs that store state between restarts have switched to the new API. The only exceptions are the log and docker/container inputs I think.

@urso
Copy link

urso commented Nov 9, 2020

@dedemorton do we want to merge this PR as is and create a follow up issue?

@dedemorton
Copy link
Contributor Author

@urso Yes, but you should create the follow-up issue because I don't think I can describe this.

@urso
Copy link

urso commented Nov 10, 2020

Follow up issue: #22513 (I hope the issue is a little more clear)

@dedemorton dedemorton merged commit b9897e8 into elastic:master Nov 10, 2020
@dedemorton dedemorton deleted the update_registry_docs branch November 10, 2020 19:12
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 10, 2020
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 10, 2020
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 10, 2020
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Jan 20, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Filebeat Filebeat needs_reviewer PR needs to be assigned a reviewer needs_team Indicates that the issue/PR needs a Team:* label v7.9.0 v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants