Do not require sudo to run filebeat in Java tutorial #22366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
❕ Flaky test reportNo test was executed to be analysed. |
💚 Build Succeeded
Expand to view the summary
Build stats
|
|
@dedemorton Thanks for doing this! |
|
you are correct regarding RPM/deb needing root as when those are used the binary is deployed as a system controlled process. LGTM, and thanks! |
bmorelli25
approved these changes
Nov 3, 2020
This was referenced Nov 3, 2020
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 3, 2020
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 3, 2020
dedemorton
added a commit
that referenced
this pull request
Nov 4, 2020
dedemorton
added a commit
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22329
@DanRoscigno I didn't change rpm/deb because I have a vague memory that sudo is required. It has been awhile since I've tested the commands, though. Let me know for sure, and I'll update the commands if necessary.
@EamonnTP FYI. I decided to create a new widget here instead of pulling in the existing one because there's so much conditional coding that isn't relevant to the tutorial. Given that the shelf life of these widgets is limited (with the new doc system on the horizon), I think it's OK to duplicate.