Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: run packaging if ^go.mod changes #22383

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 3, 2020

What does this PR do?

Add packaging stage when a ChangeRequest touches the ^go.mod files.

Why is it important?

Early detection of possible issues with the packaging.

Issues

Closes #21630

Implementation details

https://beats-ci.elastic.co/job/Beats/job/packaging/ got a pre-validation stage that only gets trigger if:

  • GitHub comment event
  • Upstream event
  • Manual UI event

Git changeset validation would require a worker, so in order to add that particular overhead we use parenstream-downstream relationship rather than the approach of dowsntream subscribed to the parentstream events.

Tests

bd1dd76

caused
image

GH checks

image

build

@v1v v1v added Packaging automation ci Team:Automation Label for the Observability productivity team labels Nov 3, 2020
@v1v v1v self-assigned this Nov 3, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2020

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16384
Skipped 1344
Total 17728

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22383 event]

  • Start Time: 2020-11-03T17:07:23.134+0000

  • Duration: 89 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 16384
Skipped 1344
Total 17728

chore: for testing purposes
@v1v v1v force-pushed the feature/packaging-go-mod-changes branch from 96823bf to bd1dd76 Compare November 3, 2020 16:45
@v1v v1v marked this pull request as ready for review November 3, 2020 17:07
@v1v v1v requested a review from a team as a code owner November 3, 2020 17:07
@mdelapenya
Copy link
Contributor

I wonder if we want to run the /packaging command with any PR 🤔

@kuisathaverat
Copy link
Contributor

generate all packages seems a little excessive, run it only for intel and Docker would be enough, but right now it is not possible to select what to build until we merged #22178 that is blocked by the GCP plugin issue.

@v1v v1v merged commit ac4a991 into elastic:master Nov 9, 2020
@v1v v1v deleted the feature/packaging-go-mod-changes branch November 9, 2020 11:57
v1v added a commit to v1v/beats that referenced this pull request Nov 9, 2020
v1v added a commit to v1v/beats that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation ci Packaging Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Launch packaging job on go.mod changes
5 participants