-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: run packaging if ^go.mod changes #22383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
Packaging
automation
ci
Team:Automation
Label for the Observability productivity team
labels
Nov 3, 2020
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Nov 3, 2020
Collaborator
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Collaborator
chore: for testing purposes
v1v
force-pushed
the
feature/packaging-go-mod-changes
branch
from
November 3, 2020 16:45
96823bf
to
bd1dd76
Compare
This reverts commit bd1dd76.
mdelapenya
approved these changes
Nov 3, 2020
I wonder if we want to run the |
generate all packages seems a little excessive, run it only for intel and Docker would be enough, but right now it is not possible to select what to build until we merged #22178 that is blocked by the GCP plugin issue. |
cachedout
approved these changes
Nov 5, 2020
kuisathaverat
approved these changes
Nov 6, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 9, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 9, 2020
v1v
added a commit
that referenced
this pull request
Nov 9, 2020
v1v
added a commit
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add packaging stage when a ChangeRequest touches the
^go.mod
files.Why is it important?
Early detection of possible issues with the packaging.
Issues
Closes #21630
Implementation details
https://beats-ci.elastic.co/job/Beats/job/packaging/ got a pre-validation stage that only gets trigger if:
Git changeset validation would require a worker, so in order to add that particular overhead we use parenstream-downstream relationship rather than the approach of dowsntream subscribed to the parentstream events.
Tests
bd1dd76
caused
GH checks
build