Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22389 to 7.x: Autodiscover ephemeral containers in kubernetes #22434

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 4, 2020

Cherry-pick of PR #22389 to 7.x branch. Original message:

Enhancement: Autodiscover ephemeral containers in kubernetes when "scrape_ephemeral_containers" flag is set to True

What does this PR do?

Adds autodiscovery of kubernetes ephemeral containers. It is disabled by default and needs to set "scrape_ephemeral_containers" flag to "True"

Why is it important?

I'm using filebeat to scrape logs of pods in my organizations kubernetes clusters, and there is currently no support for collecting logs for ephemeral containers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

  1. Set kubernetes cluster with EphemeralContainers feature gate enabled
  2. Run filebeat on kubernetes cluster with autodiscovery as in official docs.
  3. Add config flag "scrape_ephemeral_containers: True"
  4. Start ephemeral container and check if filebeat starts collecting logs

Related issues

Use cases

Add support for autodiscovery of ephemeral containers in kubernetes cluster

Screenshots

Logs

@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16345
Skipped 1367
Total 17712

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22434 opened]

  • Start Time: 2020-11-04T17:40:17.695+0000

  • Duration: 65 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 16345
Skipped 1367
Total 17712

@jsoriano jsoriano merged commit c98e0bb into elastic:7.x Nov 5, 2020
@jsoriano jsoriano deleted the backport_22389_7.x branch November 5, 2020 10:01
@zube zube bot removed the [zube]: Done label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants