Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22438 to 7.x: Fix duplicated events in kubernetes autodiscover for pods with init or ephemeral containers #22492

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 9, 2020

Cherry-pick of PR #22438 to 7.x branch. Original message:

What does this PR do?

Stop sending duplicated events for pods with init or ephemeral containers.

Why is it important?

Actually not so important because in principle duplicated events should generate the same configuration, and configurations are de-duplicated, but just in case these duplicated events have unexpected effects.

Also, an additional test is added to cover init containers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 9, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16369
Skipped 1367
Total 17736

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22492 opened]

  • Start Time: 2020-11-09T13:15:24.596+0000

  • Duration: 100 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 16369
Skipped 1367
Total 17736

@jsoriano jsoriano merged commit b7331b3 into elastic:7.x Nov 9, 2020
@jsoriano jsoriano deleted the backport_22438_7.x branch November 9, 2020 15:18
@zube zube bot removed the [zube]: Done label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants