Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22550 to 7.x: Trim down beat name if it's longer than 15 characters #22633

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Nov 17, 2020

Cherry-pick of PR #22550 to 7.x branch. Original message:

What does this PR do?

This is a fix for #21297

If a beat name is longer than 15 characters on *nix systems, it won't match the process name found by the libbeat metrics tools, which will cause the beat to bomb out. If the beat name exceeds the name in /proc/self/comm, then truncate it.

Why is it important?

Custom beats with long names can fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • create a beat with a name longer than 15 characters
  • build, make sure it runs.

Related issues

* Trim down beat name if it's longer than 15 characters

* add OS guard, changelog

(cherry picked from commit 82b8372)
@fearful-symmetry fearful-symmetry added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Nov 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 17, 2020
@fearful-symmetry fearful-symmetry requested a review from a team November 17, 2020 17:32
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22633 opened]

  • Start Time: 2020-11-17T17:32:38.877+0000

  • Duration: 71 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 16388
Skipped 1368
Total 17756

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16388
Skipped 1368
Total 17756

@fearful-symmetry fearful-symmetry merged commit 3e51d77 into elastic:7.x Nov 18, 2020
@zube zube bot removed the [zube]: Done label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants