Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22481 to 7.x: [filebeat][panw] Improve panos fileset url parsing #22670

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 19, 2020

Cherry-pick of PR #22481 to 7.x branch. Original message:

What does this PR do?

Parse panos url field to extract useful ecs fields.

Why is it important?

To improve ECS support in our modules.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* Improve panos url parsing

* Do not parse url details when not needed

* Parse url based on threat subtype

(cherry picked from commit bb973c4)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2020
@marc-gr marc-gr requested a review from a team November 19, 2020 08:45
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22670 opened]

  • Start Time: 2020-11-19T08:45:50.178+0000

  • Duration: 50 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 1967
Skipped 259
Total 2226

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1967
Skipped 259
Total 2226

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 725961c into elastic:7.x Nov 19, 2020
@marc-gr marc-gr deleted the backport_22481_7.x branch November 19, 2020 14:39
@zube zube bot removed the [zube]: Done label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants