Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21624 to 7.10: [Filebeat S3] Change log.file.path to be nested object #22672

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Cherry-pick #21624 to 7.10: [Filebeat S3] Change log.file.path to be nested object #22672

merged 1 commit into from
Nov 19, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 19, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21624 to 7.10 branch. Original message:

This PR is to change log.file.path to be nested object instead of using file.path as field name.

@marc-gr marc-gr added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 19, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2020
@marc-gr marc-gr requested a review from kaiyan-sheng November 19, 2020 10:18
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22672 opened]

  • Start Time: 2020-11-19T10:19:19.182+0000

  • Duration: 45 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@marc-gr marc-gr merged commit 0a06a03 into elastic:7.10 Nov 19, 2020
@marc-gr marc-gr deleted the backport_21624_7.10 branch November 19, 2020 12:21
kaiyan-sheng
kaiyan-sheng reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this one!

@zube zube bot removed the [zube]: Done label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@sayden sayden sayden approved these changes

Assignees
No one assigned
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-gr @elasticmachine @sayden @kaiyan-sheng