Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick to 7.x: Initial spec file for apm-server (#21225) #22811

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Dec 1, 2020

Backports the following commits to 7.x:

Start with Elasticsearch output only for now
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 1, 2020
@jalvz jalvz self-assigned this Dec 1, 2020
@jalvz jalvz added the backport label Dec 1, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 1, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22811 updated

  • Start Time: 2020-12-01T12:22:27.866+0000

  • Duration: 22 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

@jalvz jalvz requested a review from ruflin December 2, 2020 07:37
@andresrc andresrc added the Team:apm APM Server team issues/PRs label Dec 2, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2020
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but haven't run it locally.

@michalpristas Could you have a look?

@ruflin ruflin requested a review from michalpristas December 2, 2020 10:12
@jalvz
Copy link
Contributor Author

jalvz commented Dec 2, 2020

yes, would be great if someone can run it. thanks!

@jalvz
Copy link
Contributor Author

jalvz commented Dec 9, 2020

@michalpristas does this look fine to you?

@jalvz jalvz merged commit 28e2ab2 into elastic:7.x Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:apm APM Server team issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants