Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for http over unix sockets and named pipes in Metricbeat #22891

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 3, 2020

What does this PR do?

  • Add mention in common HTTP docs about supporting http+unix and http+npipe schemes to connect to UNIX sockets and Windows named pipes.
  • Add missing references to the common HTTP docs in modules that use the default URL parser and HTTP helpers.
  • Add test for http+unix using the default URL parser and the HTTP helper together.

Why is it important?

  • To better document support for HTTP over UNIX sockets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano jsoriano added review Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Dec 3, 2020
@jsoriano jsoriano self-assigned this Dec 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 3, 2020
@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.10.2 v7.11.0 labels Dec 3, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22891 opened

  • Start Time: 2020-12-03T13:04:29.195+0000

  • Duration: 62 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 2848
Skipped 630
Total 3478

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2848
Skipped 630
Total 3478

@@ -3,6 +3,7 @@
description: >
envoyproxy module
release: ga
settings: ["ssl", "http"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see this reusable component. @mtojek @ycombinator Would be great to have something like this also for the build process of integrations to pull in shared doc snippets.

@jsoriano jsoriano merged commit c2272c1 into elastic:master Dec 7, 2020
@jsoriano jsoriano deleted the doc-http-unix-support branch December 7, 2020 12:00
jsoriano added a commit to jsoriano/beats that referenced this pull request Dec 7, 2020
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Dec 7, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Dec 7, 2020
jsoriano added a commit that referenced this pull request Dec 8, 2020
jsoriano added a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants