Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fix flaky TestConfigurable* unit tests #23579

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

This PR adds a waitFor clause to TestConfigurableRun and TestConfigurableService tests.
Sometimes it happened that we were checking if process is not running anymore by checking state != Running but the process was (due to heavier load on the CI machine) still in the Configuring state. This condition then evaluated that process is not running and failed test.

Now we perform this check after we verify that status exited Configuring.

As i'm reenabling TestConfigurableService i will rekick tests multiple times and watch weekly failures mail.

Why is it important?

Flaky tests #20836

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 20, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Michal Pristas

    • Start Time: 2021-01-20T11:08:14.447+0000
  • Duration: 24 min 31 sec

  • Commit: 84f6849

Test stats 🧪

Test Results
Failed 0
Passed 1456
Skipped 2
Total 1458

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1456
Skipped 2
Total 1458

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit c6af049 into elastic:master Jan 20, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Jan 20, 2021
* wait to get out of configurable state

* reenable serviceable test
michalpristas added a commit that referenced this pull request Jan 20, 2021
)

* wait to get out of configurable state

* reenable serviceable test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants