Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22768 to 7.x: [Filebeat][New Fileset] Cisco AMP #24038

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Feb 15, 2021

Cherry-pick of PR #22768 to 7.x branch. Original message:

What does this PR do?

This PR is for adding Cisco AMP fileset to the cisco module.

Cisco AMP allows collection of endpoint events from their Events API documented here

Why is it important?

Adds support for another very commonly used Cisco product.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* initial stash for cisco amp

* stashing more cisco amp changes

* stashing httpjson v2 type config and merging with master

* stashing amp changes

* updating fields.go

* first finalized MVP for Cisco AMP

* added changelog

* This commit resolves most of the comments made to the PR

* updating pipeline based on PR feedback and comments

* updating field mapping and docs based on PR comments

(cherry picked from commit 183fae5)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24038 updated

  • Start Time: 2021-02-15T14:27:30.560+0000

  • Duration: 50 min 58 sec

  • Commit: b75440c

Test stats 🧪

Test Results
Failed 0
Passed 12967
Skipped 2047
Total 15014

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 12967
Skipped 2047
Total 15014

@P1llus P1llus merged commit 4ccad85 into elastic:7.x Feb 15, 2021
@zube zube bot removed the [zube]: Done label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants