Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 7.x: [CI] enable x-pack/heartbeat in the CI (#23873) #24113

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Cherry-pick to 7.x: [CI] enable x-pack/heartbeat in the CI (#23873) #24113

merged 1 commit into from
Feb 23, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 18, 2021

Backports the following commits to 7.x:

@v1v v1v self-assigned this Feb 18, 2021
@v1v v1v added automation backport ci Team:Automation Label for the Observability productivity team labels Feb 18, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 18, 2021
@botelastic
Copy link

botelastic bot commented Feb 18, 2021

This pull request doesn't have a Team:<team> label.

@v1v v1v requested a review from andrewvc February 18, 2021 18:15
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24113 opened

  • Start Time: 2021-02-18T17:46:10.338+0000

  • Duration: 32 min 45 sec

  • Commit: c453348

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

@v1v v1v requested a review from a team February 22, 2021 09:27
cachedout
cachedout reviewed Feb 22, 2021
View reviewed changes
x-pack/heartbeat/Jenkinsfile.yml
@@ -13,6 +13,63 @@ when:
tags: true ## for all the tags
platform: "immutable && ubuntu-18" ## default label for all the stages
stages:
Lint:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lint:
lint:

Should this be capatalized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint was there for other modules, so I'll say this is something we can tackle with a follow up to normalise the Lint stage across all the beats

@v1v v1v merged commit c97f746 into elastic:7.x Feb 23, 2021
@v1v v1v deleted the backport/7.x/pr-23873 branch February 23, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout left review comments

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees

@v1v v1v

Labels
automation backport ci Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @cachedout @kuisathaverat