[Winlogbeat] remove eventlogger #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
force-pushed
the
winlogbeat_remove_eventlogger
branch
from
bc679f5 to
0026709
Compare
andrewkroh
approved these changes
Mar 10, 2021
marc-gr
force-pushed
the
winlogbeat_remove_eventlogger
branch
from
0026709 to
d003228
Compare
Co-authored-by: Andrew Kroh <[email protected]>
6 tasks
6 tasks
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Mar 15, 2021
* Rename file * Remove deprecated eventlogging api and unused code * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 9552c3a)
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Mar 15, 2021
* Rename file * Remove deprecated eventlogging api and unused code * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 9552c3a)
marc-gr
added a commit
that referenced
this pull request
Mar 15, 2021
* Rename file * Remove deprecated eventlogging api and unused code * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 9552c3a)
marc-gr
added a commit
that referenced
this pull request
Mar 15, 2021
* Rename file * Remove deprecated eventlogging api and unused code * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 9552c3a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Rename file * Remove deprecated eventlogging api and unused code * Update CHANGELOG.next.asciidoc Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit 12c8210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes code related to
eventloggerAPI, which was used for Windows XP, Windows Server 2000 and Windows Server 2003 which are not supported by us or Go anymore.I added a deprecation warning and a fallback to use the
wineventlogapi in case someone is using specifically theeventloggervalue as an option in the config, but I am tempted to removing it. WDYT?Also added it in the changelog under
Addedbut doubt if it should go onBreaking changesWhy is it important?
Cleanup dead code.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.