Cherry-pick #24489 to 7.12: [Elastic Agent] Add verification check when updating communication to Kibana. #24520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Kibana. (elastic#24489) * Add verification check when updating communication to Kibana. * Add changelog. * Add const. (cherry picked from commit ad3300d)
blakerouse
added
[zube]: In Review
backport
Team:Elastic-Agent
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
kaiyan-sheng
approved these changes
Mar 15, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… Kibana. (elastic#24489) (elastic#24520) * Add verification check when updating communication to Kibana. * Add changelog. * Add const. (cherry picked from commit 5da3bd8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24489 to 7.12 branch. Original message:
What does this PR do?
Adds a verification check when updating how the Elastic Agent communicates with Kibana. Ensures that the Elastic Agent reports Failed when an error occurs dispatching action.
Why is it important?
Currently if the user has the global Kibana connection information wrong in the policies Elastic Agent will update the client and then fail to checkin. This ensures that before updating to a new client that the new client can actually communicate with Kibana. In the case that it cannot communicate it updates the Elastic Agent as failed and reports back to the original client that the action of updating the policy failed.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues