Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module sophosxg > junos #24750

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Module sophosxg > junos #24750

merged 2 commits into from
Mar 29, 2021

Conversation

stefnestor
Copy link
Contributor

What does this PR do?

New to Juniper docs topic, but confused why the sophosxg module is referenced under the junos module.

Why is it important?

Legibility

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • NA: I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

guide/en/beats/filebeat/current/filebeat-module-juniper.html#_compatibility_19

image

@stefnestor
Module sophosxg > junos
b5dc907 
New to topic, but confused why the sophosxg module is referenced under the junos module.
@stefnestor stefnestor added enhancement docs Team:Docs Label for the Observability docs team labels Mar 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 24, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 24, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24750 updated

  • Start Time: 2021-03-26T15:33:30.411+0000

  • Duration: 23 min 37 sec

  • Commit: af76fe6

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

EamonnTP
EamonnTP approved these changes Mar 25, 2021
View reviewed changes
Copy link

@EamonnTP EamonnTP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This PR will also need back ported to the 7.x and 7.12 branches.

@EamonnTP
Copy link

jenkins run the tests please

@stefnestor
Copy link
Contributor Author

This PR will also need back ported to the 7.x and 7.12 branches.

I don't know how to do that. I'm following this https://wiki.elastic.co/display/CC/Filing+documentation+issues+for+Elastic+Cloud. May I have help?

@EamonnTP
Copy link

Yes no problem at all. I can back port the PR for you. I will run the checks again to see if they will pass.

@EamonnTP
Copy link

jenkins run the tests please

@EamonnTP
Copy link

Apologies @stefnestor I have just realised that you have edited a generated file (see This file is generated at the top of the file). The source file needs to be edited instead, which is here: https://github.com/elastic/beats/blob/master/x-pack/filebeat/module/juniper/_meta/docs.asciidoc

After you update the source file, you run mage fmt update which will then update the generated file.

@stefnestor
Copy link
Contributor Author

Interesting, thanks for the update! Sorry for my bad. I don't know how to edit that file when using the website's ?Edit button. Is it ok if I just do a normal forked-pull request or does doing that flow have special implications I'll miss?

@stefnestor stefnestor mentioned this pull request Mar 25, 2021
Closed
6 tasks
@stefnestor
Copy link
Contributor Author

If it can, then I've filed #24772 & we can close here 😌 -- if not, 😬 sorry, I'll try again

@EamonnTP EamonnTP requested a review from bmorelli25 March 26, 2021 15:38
bmorelli25
bmorelli25 reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update, @stefnestor!

@EamonnTP EamonnTP merged commit 4e9946d into master Mar 29, 2021
This was referenced Mar 29, 2021
Merged
Merged
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Mar 29, 2021
@stefnestor
Module sophosxg > junos (elastic#24750)
a0d67fe 
* Module sophosxg > junos

New to topic, but confused why the sophosxg module is referenced under the junos module.

* Update source file

Co-authored-by: Eamonn Smith <[email protected]>
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Mar 29, 2021
@stefnestor
Module sophosxg > junos (elastic#24750)
3b8d135 
* Module sophosxg > junos

New to topic, but confused why the sophosxg module is referenced under the junos module.

* Update source file

Co-authored-by: Eamonn Smith <[email protected]>
EamonnTP pushed a commit that referenced this pull request Mar 29, 2021
@stefnestor
Module sophosxg > junos (#24750) (#24818)
defdfe1 
* Module sophosxg > junos

New to topic, but confused why the sophosxg module is referenced under the junos module.

* Update source file

Co-authored-by: Eamonn Smith <[email protected]>

Co-authored-by: Stef Nestor <[email protected]>
EamonnTP pushed a commit that referenced this pull request Mar 29, 2021
@stefnestor
Module sophosxg > junos (#24750) (#24819)
75a7611 
* Module sophosxg > junos

New to topic, but confused why the sophosxg module is referenced under the junos module.

* Update source file

Co-authored-by: Eamonn Smith <[email protected]>

Co-authored-by: Stef Nestor <[email protected]>
@EamonnTP EamonnTP deleted the stefnestor-patch-1 branch March 29, 2021 16:31
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@stefnestor
Module sophosxg > junos (elastic#24750) (elastic#24819)
33b310b 
* Module sophosxg > junos

New to topic, but confused why the sophosxg module is referenced under the junos module.

* Update source file

Co-authored-by: Eamonn Smith <[email protected]>

Co-authored-by: Stef Nestor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@EamonnTP EamonnTP EamonnTP approved these changes

Assignees
No one assigned
Labels
docs enhancement Team:Docs Label for the Observability docs team v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefnestor @elasticmachine @EamonnTP @bmorelli25