Cherry-pick #23287 to 7.x: [Metricbeat] Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Couchbase module #24903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#23287) They were defined as long, but they can be floats. (cherry picked from commit 38dac25)
jsoriano
added
[zube]: In Review
backport
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23287 to 7.x branch. Original message:
Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Metricbeat Couchbase module (#21021)
What does this PR do?
The struct
NodeInterestingStatsin Metricbeat Couchbase module has the fieldsGetHitsandOpswith a type ofint64. But according the the issue (#21021) Couchbase returns a float for these fields. This pull requests will change those fields tofloat64.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run the Go tests in the node package. The values for the fields in
data.jsonhave been changed so a float is used as input and as expected value.Related issues
Closes #21021