Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24861 to 7.x: [Filebeat] Fix hardcoded amazonaws.com endpoint #25009

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Cherry-pick #24861 to 7.x: [Filebeat] Fix hardcoded amazonaws.com endpoint #25009

merged 1 commit into from
Apr 10, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 9, 2021

Cherry-pick of PR #24861 to 7.x branch. Original message:

What does this PR do?

Updates the S3 input validation for the queue url to check for the amazonaws.com domain or for the domain to match the endpoint config parameter that already exists.

Why is it important?

Adds the ability for to use non amazonaws.com domains for Filebeat S3 input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

closes #24420

Use cases

Screenshots

Logs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 9, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 9, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25009 opened

  • Start Time: 2021-04-09T14:47:40.610+0000

  • Duration: 71 min 44 sec

  • Commit: 4ab9a2a

Test stats 🧪

Test Results
Failed 0
Passed 6883
Skipped 1185
Total 8068

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6883
Skipped 1185
Total 8068

@kaiyan-sheng kaiyan-sheng merged commit 7428953 into elastic:7.x Apr 10, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_24861_7.x branch April 10, 2021 13:52
@zube zube bot removed the [zube]: Done label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants