Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #26604 to 7.x: Indenting correction for module configuration example #27565

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 24, 2021

Cherry-pick of PR #26604 to 7.x branch. Original message:

What does this PR do?

Fix YAML indenting for module configuration example

Why is it important?

The example given was invalid

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

* Removed outdated documentation

* Typo fix

* Corrected indenting for module configuration example

* Made changes in the _meta directory

* mage update

* changelog

Co-authored-by: narph <[email protected]>
(cherry picked from commit abf329b)
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Aug 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 24, 2021
@narph narph self-assigned this Aug 24, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-24T08:28:00.236+0000

  • Duration: 20 min 22 sec

  • Commit: e03d1bb

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@narph narph merged commit ea60afb into elastic:7.x Aug 24, 2021
@narph narph deleted the backport_26604_7.x branch August 24, 2021 08:51
@zube zube bot removed the [zube]: Done label Nov 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b backport_26604_7.x upstream/backport_26604_7.x
git merge upstream/7.x
git push upstream backport_26604_7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants