-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat sophos xg bring back the system health pipeline. #27826 #27827
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This is still a work in progress, I just discovered that the original pipeline was not matched to ECS properly. So gonna take some time to resolve this. |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have some samples of these System Health logs so that we can add them to the test suite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two small comments
x-pack/filebeat/module/sophos/xg/test/system-health.log-expected.json
Outdated
Show resolved
Hide resolved
This pull request is now in conflicts. Could you fix it? 🙏
|
Bring back the system health pipeline. Closes #27826 Co-authored-by: Adrian Serrano <[email protected]> (cherry picked from commit c3476c7)
Bring back the system health pipeline. Closes #27826 Co-authored-by: Adrian Serrano <[email protected]> (cherry picked from commit c3476c7)
Bring back the system health pipeline. Closes #27826 Co-authored-by: Philipp Kahr <[email protected]> Co-authored-by: Adrian Serrano <[email protected]>
Bring back the system health pipeline. Closes #27826 (cherry picked from commit c3476c7) Co-authored-by: Philipp Kahr <[email protected]> Co-authored-by: Adrian Serrano <[email protected]>
Bring back the system health pipeline. Closes elastic#27826 Co-authored-by: Adrian Serrano <[email protected]>
What does this PR do?
Brings back the system health pipeline
Why is it important?
We are supporting sophos xg module, however our pipeline.yml references to a non existing system health pipeline. This was first removed (as far as me digging through the git history in this commit)
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues