Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat sophos xg bring back the system health pipeline. #27826 #27827

Merged
merged 17 commits into from
Sep 22, 2021

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Sep 9, 2021

What does this PR do?

Brings back the system health pipeline

Why is it important?

We are supporting sophos xg module, however our pipeline.yml references to a non existing system health pipeline. This was first removed (as far as me digging through the git history in this commit)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@philippkahr philippkahr added the bug label Sep 9, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2021
@philippkahr philippkahr changed the title Bring back the system health pipeline. #27826 Filebeat sophos xg Bring back the system health pipeline. #27826 Sep 9, 2021
@philippkahr philippkahr changed the title Filebeat sophos xg Bring back the system health pipeline. #27826 Filebeat sophos xg bring back the system health pipeline. #27826 Sep 9, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-22T09:43:20.148+0000

  • Duration: 101 min 33 sec

  • Commit: 3ad01d5

Test stats 🧪

Test Results
Failed 0
Passed 8208
Skipped 1201
Total 9409

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8208
Skipped 1201
Total 9409

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-sophos-module upstream/fix-sophos-module
git merge upstream/master
git push upstream fix-sophos-module

@philippkahr
Copy link
Contributor Author

This is still a work in progress, I just discovered that the original pipeline was not matched to ECS properly. So gonna take some time to resolve this.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2021
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some samples of these System Health logs so that we can add them to the test suite?

@adriansr adriansr requested a review from P1llus September 20, 2021 15:15
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two small comments

@adriansr adriansr added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Sep 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-sophos-module upstream/fix-sophos-module
git merge upstream/master
git push upstream fix-sophos-module

@adriansr adriansr merged commit c3476c7 into elastic:master Sep 22, 2021
mergify bot pushed a commit that referenced this pull request Sep 22, 2021
Bring back the system health pipeline.

Closes #27826

Co-authored-by: Adrian Serrano <[email protected]>
(cherry picked from commit c3476c7)
mergify bot pushed a commit that referenced this pull request Sep 22, 2021
Bring back the system health pipeline.

Closes #27826

Co-authored-by: Adrian Serrano <[email protected]>
(cherry picked from commit c3476c7)
adriansr added a commit that referenced this pull request Sep 23, 2021
Bring back the system health pipeline.

Closes #27826

Co-authored-by: Philipp Kahr <[email protected]>
Co-authored-by: Adrian Serrano <[email protected]>
adriansr added a commit that referenced this pull request Sep 23, 2021
Bring back the system health pipeline.

Closes #27826

(cherry picked from commit c3476c7)

Co-authored-by: Philipp Kahr <[email protected]>
Co-authored-by: Adrian Serrano <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Bring back the system health pipeline.

Closes elastic#27826

Co-authored-by: Adrian Serrano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Sophos module pipeline.yml references to missing system health pipeline
5 participants