-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang Cloud Functions in Functionbeat to use Golang 1.16.x on GCP #28251
Conversation
This pull request does not have a backport label. Could you fix it @kvch? 🙏
NOTE: |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
I'm trying to test this, but I keep getting a build failed error:
What I did so far:
But I get the error shown above. Any clue? Am I doing something wrong? |
Closing as even if we release this, it will be supported only for a few weeks. |
For reference, the alternative is to use GCP Dataflow (available since 7.15). |
What about consumers that want to push to logstash :( |
What does this PR do?
This PR adopts Golang 1.16 in cloud functions and removes vendoring in favour of go.mod files.
Why is it important?
Previously, GCP functions were broken.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Closes #28132