Add request id to HTTP transactions to allow tracking. #28590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label. Could you fix it @scunningham? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
scunningham
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
removed
the
needs_team
|
/test |
2 similar comments
|
/test |
|
/test |
added 2 commits
November 1, 2021 09:29
…xy into Fleet Server and back.
scunningham
force-pushed
the
feature/agent_reqid
branch
from
e3fc982 to
48b8b49
Compare
aleksmaus
approved these changes
Nov 1, 2021
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Add request id to HTTP transactions to allow tracking through the proxy into Fleet Server and back. * Linter fix (cherry picked from commit 6288ccc)
scunningham
removed
the
backport-skip
scunningham
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Add request id to HTTP transactions to allow tracking through the proxy into Fleet Server and back. * Linter fix (cherry picked from commit 6288ccc) Co-authored-by: Sean Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the "X-Request-ID" header to HTTP transactions with Fleet Server.
Why is it important?
This allows tracking of the transaction through the cloud proxy and into Fleet Server. The request Id can be aligned across log entries.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.