Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Beat generators #28816

Merged
merged 8 commits into from
Nov 5, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-developer.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ The list below covers the major changes between 7.0.0-rc2 and master only.
- Remove Metricbeat EventFetcher and EventsFetcher interface. Use the reporter interface instead. {pull}25093[25093]
- Update Darwin build image to a debian 10 base that increases the MacOS SDK and minimum supported version used in build to 10.14. {issue}24193[24193]
- Removed the `common.Float` type. {issue}28279[28279] {pull}28280[28280] {pull}28376[28376]
- Removed Beat generators. {pull}28816[28816]

==== Bugfixes

Expand Down
2 changes: 0 additions & 2 deletions Jenkinsfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ projects:
- "auditbeat"
- "deploy/kubernetes"
- "filebeat"
# Skipping because they are failing, see https://github.com/elastic/beats/pull/28723
#- "generator"
- "heartbeat"
- "libbeat"
- "metricbeat"
Expand Down
11 changes: 3 additions & 8 deletions dev-tools/mage/fmt.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,10 @@ func Format() {
mg.Deps(GoImports, PythonAutopep8)
}

// GoImports executes goimports against all .go files in and below the CWD. It
// ignores vendor/ and generator/_templates/ directories.
// GoImports executes goimports against all .go files in and below the CWD.
func GoImports() error {
goFiles, err := FindFilesRecursive(func(path string, _ os.FileInfo) bool {
return filepath.Ext(path) == ".go" &&
!strings.Contains(path, "vendor/") &&
kvch marked this conversation as resolved.
Show resolved Hide resolved
!strings.Contains(path, "generator/_templates/")
return filepath.Ext(path) == ".go"
})
if err != nil {
return err
Expand Down Expand Up @@ -84,9 +81,7 @@ func GoImports() error {
// ignores build/ directories.
func PythonAutopep8() error {
pyFiles, err := FindFilesRecursive(func(path string, _ os.FileInfo) bool {
return filepath.Ext(path) == ".py" &&
!strings.Contains(path, "build/") &&
!strings.Contains(path, "vendor/")
return filepath.Ext(path) == ".py" && !strings.Contains(path, "build/")
})
if err != nil {
return err
Expand Down
11 changes: 0 additions & 11 deletions docs/devguide/contributing.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,6 @@ In the pull request, describe what your changes do and mention
any bugs/issues related to the pull request. Please also add a changelog entry to
https://github.com/elastic/beats/blob/master/CHANGELOG.next.asciidoc[CHANGELOG.next.asciidoc].

[float]
[[adding-new-beat]]
=== Adding a New Beat

If you want to create a new Beat, please read <<new-beat>>. You don't need to
submit the code to this repository. Most new Beats start in their own repository
and just make use of the libbeat packages. After you have a working Beat that
you'd like to share with others, open a PR to add it to our list of
https://github.com/elastic/beats/blob/master/libbeat/docs/communitybeats.asciidoc[community
Beats].

[float]
[[setting-up-dev-environment]]
=== Setting Up Your Dev Environment
Expand Down
319 changes: 0 additions & 319 deletions docs/devguide/create-metricset.asciidoc

This file was deleted.

Loading