Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[heartbeat][agent] Remove unnecessary cups dependency #28853

Merged
merged 2 commits into from
Nov 9, 2021
Merged

[heartbeat][agent] Remove unnecessary cups dependency #28853

merged 2 commits into from
Nov 9, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Nov 5, 2021 •
edited
Loading

We currently install cups mistakenly, it's not needed to support
chromium browsers.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc
[heartbeat][agent] Remove unnecessary cups dependency
d4e98e8 
We currently install cups mistakenly, it's not needed to support
chromium browsers.
@andrewvc andrewvc requested a review from justinkambic November 5, 2021 20:17
@andrewvc andrewvc self-assigned this Nov 5, 2021
@andrewvc andrewvc requested a review from a team as a code owner November 5, 2021 20:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2021
@andrewvc andrewvc added backport-v7.16.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.16.0 labels Nov 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 5, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-05T23:48:44.235+0000

  • Duration: 166 min 57 sec

  • Commit: 48487de

Test stats 🧪

Test Results
Failed 0
Passed 33816
Skipped 3948
Total 37764

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

vigneshshanmugam
vigneshshanmugam approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinkambic
justinkambic approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did not do any real-world testing. LMK if needed.

@andrewvc
Copy link
Contributor Author

andrewvc commented Nov 5, 2021

/test

@andrewvc andrewvc merged commit 3bcefa2 into elastic:master Nov 9, 2021
@andrewvc andrewvc deleted the rm-cups branch November 9, 2021 13:44
mergify bot pushed a commit that referenced this pull request Nov 9, 2021
@andrewvc
[heartbeat][agent] Remove unnecessary cups dependency (#28853)
8330c35 
* [heartbeat][agent] Remove unnecessary cups dependency

We currently install cups mistakenly, it's not needed to support
chromium browsers.

* CHANGELOG

(cherry picked from commit 3bcefa2)
@mergify mergify bot mentioned this pull request Nov 9, 2021
Merged
@andrewvc
Copy link
Contributor Author

@Mergifyio backport 8.0

mergify bot pushed a commit that referenced this pull request Nov 16, 2021
@andrewvc
[heartbeat][agent] Remove unnecessary cups dependency (#28853)
bcac6a5 
* [heartbeat][agent] Remove unnecessary cups dependency

We currently install cups mistakenly, it's not needed to support
chromium browsers.

* CHANGELOG

(cherry picked from commit 3bcefa2)
@mergify mergify bot mentioned this pull request Nov 16, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

backport 8.0

✅ Backports have been created

andrewvc pushed a commit that referenced this pull request Nov 16, 2021
@mergify
[heartbeat][agent] Remove unnecessary cups dependency (#28853) (#28893)
d7e87e2
andrewvc added a commit that referenced this pull request Nov 16, 2021
@mergify @andrewvc
[heartbeat][agent] Remove unnecessary cups dependency (#28853) (#28987)
2a151c7 
* [heartbeat][agent] Remove unnecessary cups dependency

We currently install cups mistakenly, it's not needed to support
chromium browsers.

* CHANGELOG

(cherry picked from commit 3bcefa2)

Co-authored-by: Andrew Cholakian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@justinkambic justinkambic justinkambic approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v7.16.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewvc @elasticmachine @vigneshshanmugam @justinkambic