Add username/pass options for PostgreSQL #2890
Conversation
| # The available parameters are documented here: | ||
| # https://godoc.org/github.com/lib/pq#hdr-Connection_String_Parameters | ||
| #hosts: ["postgres://postgres@localhost:5432"] | ||
| # | ||
| # Warning: specifying the user/password in the hosts array is possible |
There was a problem hiding this comment.
Not sure if I would add this to the beat.full.yml as not all parts which are in the docs also have to be in the config file. As long as we removed username / password from the example and have username / password below I don't think we need to add this here. It will make it only harder to keep it up-to-date in case of changes.
There was a problem hiding this comment.
You missed it in the mongo PR then :-)
I worry that people will still add the user/pass to the connection string because that's how they are used from other software, and then be surprised to see we've indexed the password. Maybe I'm overreacting here, happy to also take it out. But I guess once we do the sanitization part we take out the warnings and we're done with it.
There was a problem hiding this comment.
Yep, I realised when I wrote that, that i missed it there but that was too late ;-)
Taking it out later SGTM.
tsg
force-pushed
the
postgres_user_and_pass
branch
from
d6cabef to
7a8e8a0
Compare
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL.
tsg
force-pushed
the
postgres_user_and_pass
branch
from
7a8e8a0 to
c2db024
Compare
|
LGTM |
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f0b52e1)
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f0b52e1)
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f1fb61d)
Similar to #2889 but for PostgreSQL. Also adds docs to the Postgres module,
which were missing, and adjusted the integration tests to use the username
option instead of the full URL.