-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Winlogbeat] Fix AccessList & AccessMask processing in security data_stream #29016
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @leehinman? 🙏
NOTE: |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label. Could you fix it @leehinman? 🙏
NOTE: |
5fb5da7
to
653fe23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- According to MS documentation examples AccessList contains a space separated list of access masks and AccessMask contains an integer. - Retain old behavior if AccessMask contains a space separated list of access masks - Add new code to parse AccessList as space separated list of access masks - Add new code to parse AccessMask if an integer
653fe23
to
b3d6698
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
- According to MS documentation examples AccessList contains a space separated list of access masks and AccessMask contains an integer. - Retain old behavior if AccessMask contains a space separated list of access masks - Add new code to parse AccessList as space separated list of access masks - Add new code to parse AccessMask if an integer (cherry picked from commit 7323a63)
- According to MS documentation examples AccessList contains a space separated list of access masks and AccessMask contains an integer. - Retain old behavior if AccessMask contains a space separated list of access masks - Add new code to parse AccessList as space separated list of access masks - Add new code to parse AccessMask if an integer (cherry picked from commit 7323a63)
… (#29056) - According to MS documentation examples AccessList contains a space separated list of access masks and AccessMask contains an integer. - Retain old behavior if AccessMask contains a space separated list of access masks - Add new code to parse AccessList as space separated list of access masks - Add new code to parse AccessMask if an integer (cherry picked from commit 7323a63) Co-authored-by: Lee E Hinman <[email protected]>
… (#29055) - According to MS documentation examples AccessList contains a space separated list of access masks and AccessMask contains an integer. - Retain old behavior if AccessMask contains a space separated list of access masks - Add new code to parse AccessList as space separated list of access masks - Add new code to parse AccessMask if an integer (cherry picked from commit 7323a63) Co-authored-by: Lee E Hinman <[email protected]>
…ws-on-file-changes * upstream/master: Fix discovery of Nomad allocations (elastic#28700) Add null (`\u0000`) as a valid line terminator (elastic#28998) Remove `logging.files.suffix` option and always use datetime suffixes (elastic#28927) x-pack/filebeat/module: add note for default var.input (elastic#28324) Fix AccessList & AccessMask processing in security data_stream (elastic#29016) [Metricbeat] Fix wrong mapping on "info" subkey (elastic#28782) ci: daily/weekly jobs (elastic#29050) [mergify] report open backported PRs once a week (elastic#28964)
What does this PR do?
separated list of access masks and AccessMask contains an integer.
list of access masks
access masks
Why is it important?
Sometimes AccessList and AccessMask were parsed incorrectly
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues