Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update filebeat dissect processor field tokenization example #29680

Merged
merged 1 commit into from
Jan 18, 2022
Merged

doc: update filebeat dissect processor field tokenization example #29680

merged 1 commit into from
Jan 18, 2022

Conversation

inge4pres
Copy link
Contributor

What does this PR do?

Improves documentation for the filebeat dissect processor.

Why is it important?

The dissect processor has only 1 example of configuration with (possibly) an error in the suggested syntax.
I came across it while trying to setup a filebeat instance.

https://www.elastic.co/guide/en/beats/filebeat/current/dissect.html#dissect-example

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Deos the changelog need to be updated for doc-only changes?

Author's Checklist

  • Validate the information changed in the doc actually reflects reality, the suggested content is my guess after a quick look at the code, but I didn't write a test for it

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 4, 2022
@inge4pres inge4pres changed the title doc: filebeat dissect processor field tokenization doc: update filebeat dissect processor field tokenization example Jan 4, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-04T15:31:55.510+0000

  • Duration: 20 min 21 sec

  • Commit: d9ccefa

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ChrsMark ChrsMark added the Team:Elastic-Agent Label for the Agent team label Jan 10, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 10, 2022
@jlind23 jlind23 requested a review from a team January 10, 2022 09:54
@kvch kvch added backport-v7.16.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify labels Jan 18, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@kvch kvch merged commit e1ca29d into elastic:master Jan 18, 2022
mergify bot pushed a commit that referenced this pull request Jan 18, 2022
@inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
d267659 
…29680)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)
@mergify mergify bot mentioned this pull request Jan 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jan 18, 2022
@inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
ca55708 
…29680)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)
@mergify mergify bot mentioned this pull request Jan 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jan 18, 2022
@inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
2517228 
…29680)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)
@mergify mergify bot mentioned this pull request Jan 18, 2022
Merged
kvch pushed a commit that referenced this pull request Jan 18, 2022
@mergify @inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
9048983 
…29680) (#29882)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)

Co-authored-by: Francesco Gualazzi <[email protected]>
kvch pushed a commit that referenced this pull request Jan 18, 2022
@mergify @inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
87cc0f9 
…29680) (#29883)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)

Co-authored-by: Francesco Gualazzi <[email protected]>
kvch pushed a commit that referenced this pull request Jan 18, 2022
@mergify @inge4pres
Fix Filebeat dissect processor field tokenization in documentation (#…
1611d61 
…29680) (#29884)

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit e1ca29d)

Co-authored-by: Francesco Gualazzi <[email protected]>
v1v added a commit that referenced this pull request Jan 28, 2022
@v1v
Merge remote-tracking branch 'upstream/7.17' into v1v-patch-1
c28c548 
* upstream/7.17: (30 commits)
  [7.17](backport #29966) Add the Elastic product origin header when talking to Elasticsearch or Kibana. (#30000)
  [Heartbeat] Change size of data on ICMP packet (#29948) (#29978)
  Add clarification about enableing dashboard loading (#29985) (#29989)
  Improve aws-s3 gzip file detection to avoid false negatives (#29969) (#29974)
  ci: docker login step for pulling then pushing (#29960) (#29963)
  x-pack/auditbeat/module/system/socket: get full length path and arg from /proc when not available from kprobe (#29410) (#29958)
  [Automation] Update elastic stack version to 7.17.0-ab4975a2 for testing (#29956)
  [Automation] Update elastic stack version to 7.17.0-1bd58b32 for testing (#29938)
  [7.17](backport #29913) [Metricbeat] gcp.gke: fix overview dashboard (#29914)
  [7.17](backport #29605) Fix annotation enrichment (#29834)
  [Automation] Update elastic stack version to 7.17.0-e1efbe3a for testing (#29922)
  [Automation] Update elastic stack version to 7.17.0-68da5d12 for testing (#29904)
  [7.17][Heartbeat] Defer monitor / ICMP errors to monitor runtime / ES (backport #29413) (#29896)
  Merge pull request from GHSA-rj4h-hqvq-cc6q
  [7.17](backport #29681) Change docker image from CentOS 7 to Ubuntu 20.04 (#29817)
  Fix YAML indentation in `parsers` examples (#29663) (#29894)
  [Automation] Update elastic stack version to 7.17.0-079761a0 for testing (#29864)
  Fix Filebeat dissect processor field tokenization in documentation (#29680) (#29883)
  Enable require_alias for Bulk requests for all actions when target is a write alias (#29879)
  Update Index template loading guide to use the correct endpoint (#29869) (#29877)
  ...
yashtewari pushed a commit to build-security/beats that referenced this pull request Jan 30, 2022
@inge4pres @yashtewari
Fix Filebeat dissect processor field tokenization in documentation (e…
0d858fb 
…lastic#29680)

Signed-off-by: inge4pres <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Merge remote-tracking branch 'upstream/7.17' into v1v-patch-1
82291ab 
* upstream/7.17: (30 commits)
  [7.17](backport elastic#29966) Add the Elastic product origin header when talking to Elasticsearch or Kibana. (elastic#30000)
  [Heartbeat] Change size of data on ICMP packet (elastic#29948) (elastic#29978)
  Add clarification about enableing dashboard loading (elastic#29985) (elastic#29989)
  Improve aws-s3 gzip file detection to avoid false negatives (elastic#29969) (elastic#29974)
  ci: docker login step for pulling then pushing (elastic#29960) (elastic#29963)
  x-pack/auditbeat/module/system/socket: get full length path and arg from /proc when not available from kprobe (elastic#29410) (elastic#29958)
  [Automation] Update elastic stack version to 7.17.0-ab4975a2 for testing (elastic#29956)
  [Automation] Update elastic stack version to 7.17.0-1bd58b32 for testing (elastic#29938)
  [7.17](backport elastic#29913) [Metricbeat] gcp.gke: fix overview dashboard (elastic#29914)
  [7.17](backport elastic#29605) Fix annotation enrichment (elastic#29834)
  [Automation] Update elastic stack version to 7.17.0-e1efbe3a for testing (elastic#29922)
  [Automation] Update elastic stack version to 7.17.0-68da5d12 for testing (elastic#29904)
  [7.17][Heartbeat] Defer monitor / ICMP errors to monitor runtime / ES (backport elastic#29413) (elastic#29896)
  Merge pull request from GHSA-rj4h-hqvq-cc6q
  [7.17](backport elastic#29681) Change docker image from CentOS 7 to Ubuntu 20.04 (elastic#29817)
  Fix YAML indentation in `parsers` examples (elastic#29663) (elastic#29894)
  [Automation] Update elastic stack version to 7.17.0-079761a0 for testing (elastic#29864)
  Fix Filebeat dissect processor field tokenization in documentation (elastic#29680) (elastic#29883)
  Enable require_alias for Bulk requests for all actions when target is a write alias (elastic#29879)
  Update Index template loading guide to use the correct endpoint (elastic#29869) (elastic#29877)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify docs Filebeat Filebeat Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inge4pres @elasticmachine @kvch @ChrsMark