[Filebeat][CometD] Add CometD input for Salesforce connector #30089

yug-rajani · 2022-01-28T13:02:09Z

Enhancement

What does this PR do?

Real-time logs from the Salesforce Streaming API can be collected using the cometD input. For example, live Login & Logout related logs.

Right now with this PR, when the cometd input is enabled, you can start seeing the authentication log messages that are retrieved after successful authentication using the credentials provided as a part of the configuration. You will also be able to see the real-time data being collected from the Salesforce Steaming API.
For configuration:

- type: cometd
  channel_name: /event/LoginEventStream
  auth.oauth2:
    client.id: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    client.secret: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    token_url: https://login.salesforce.com/services/oauth2/token
    user: [email protected]
    password: P@$$W0₹D

Why is it important?

It is a prerequisite for the Salesforce Observability Connector for the collection of real-time data from the Streaming APIs.
With all the different logs in cometD from different services, it will be good to have a dedicated Filebeat input to retrieve the same using cometD.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…context

…om/kush-elastic/beats into salesforce_cometd_input

mergify · 2022-01-28T13:02:37Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b salesforce_cometd_input upstream/salesforce_cometd_input
git merge upstream/master
git push upstream salesforce_cometd_input

mergify · 2022-01-28T13:02:38Z

This pull request does not have a backport label. Could you fix it @yug-elastic? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

yug-rajani · 2022-01-28T13:19:30Z

I'm not sure where the following changelog entry should be added for this PR. Kindly point me to the right direction. Thanks!

- Add cometD input to retrieve logs from Salesforce Streaming API. {pull}30089[30089]

elasticmachine · 2022-01-28T13:33:08Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-02T13:57:54.941+0000
Duration: 139 min 11 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

yug-rajani · 2022-01-28T15:07:49Z

/test

yug-rajani · 2022-01-31T07:49:33Z

Here, the lint is getting failed because of the following reason:
go.mod: needs update
I suspect that the issue is with the import of the forked repository whose owner is kush-elastic. Can someone please guide me?
I tried running mage build and mage check which did run successfully locally.

CC: @mtojek

mtojek · 2022-02-01T09:10:41Z

@yug-crest Please take a look at the consoleText output for the build. Search for "go.mod" and you will see the following dump:

[2022-01-30T02:43:19.999Z] >> fmt - go-licenser: Checking for missing headers
[2022-01-30T02:43:20.260Z] make[1]: Leaving directory '/var/lib/jenkins/workspace/Beats_beats_PR-30089/src/github.com/elastic/beats'
[2022-01-30T02:43:20.260Z] make[1]: Entering directory '/var/lib/jenkins/workspace/Beats_beats_PR-30089/src/github.com/elastic/beats'
[2022-01-30T02:43:21.210Z] make[1]: Leaving directory '/var/lib/jenkins/workspace/Beats_beats_PR-30089/src/github.com/elastic/beats'
[2022-01-30T02:43:21.210Z] make[1]: Entering directory '/var/lib/jenkins/workspace/Beats_beats_PR-30089/src/github.com/elastic/beats'
[2022-01-30T02:43:23.759Z] diff --git a/NOTICE.txt b/NOTICE.txt
[2022-01-30T02:43:23.759Z] index 75163cd38c..d811d05814 100644
[2022-01-30T02:43:23.759Z] --- a/NOTICE.txt
[2022-01-30T02:43:23.759Z] +++ b/NOTICE.txt
[2022-01-30T02:43:23.759Z] @@ -12408,6 +12408,37 @@ freely, subject to the following restrictions:
[2022-01-30T02:43:23.759Z]     distribution.
[2022-01-30T02:43:23.759Z]  
[2022-01-30T02:43:23.759Z]  
[2022-01-30T02:43:23.759Z] +--------------------------------------------------------------------------------
[2022-01-30T02:43:23.759Z] +Dependency : github.com/kush-elastic/bayeux
[2022-01-30T02:43:23.759Z] +Version: v1.0.1
[2022-01-30T02:43:23.759Z] +Licence type (autodetected): MIT
[2022-01-30T02:43:23.759Z] +--------------------------------------------------------------------------------
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +Contents of probable licence file $GOMODCACHE/github.com/kush-elastic/[email protected]/LICENSE:
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +MIT License
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +Copyright (c) 2017 Zander Hill
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +Permission is hereby granted, free of charge, to any person obtaining a copy
[2022-01-30T02:43:23.759Z] +of this software and associated documentation files (the "Software"), to deal
[2022-01-30T02:43:23.759Z] +in the Software without restriction, including without limitation the rights
[2022-01-30T02:43:23.759Z] +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
[2022-01-30T02:43:23.759Z] +copies of the Software, and to permit persons to whom the Software is
[2022-01-30T02:43:23.759Z] +furnished to do so, subject to the following conditions:
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +The above copyright notice and this permission notice shall be included in all
[2022-01-30T02:43:23.759Z] +copies or substantial portions of the Software.
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
[2022-01-30T02:43:23.759Z] +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
[2022-01-30T02:43:23.759Z] +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
[2022-01-30T02:43:23.759Z] +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
[2022-01-30T02:43:23.759Z] +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
[2022-01-30T02:43:23.759Z] +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
[2022-01-30T02:43:23.759Z] +SOFTWARE.
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z]  --------------------------------------------------------------------------------
[2022-01-30T02:43:23.759Z]  Dependency : github.com/lib/pq
[2022-01-30T02:43:23.759Z]  Version: v1.10.3
[2022-01-30T02:43:23.759Z] diff --git a/go.mod b/go.mod
[2022-01-30T02:43:23.759Z] index 7fbb47fabf..d388153171 100644
[2022-01-30T02:43:23.759Z] --- a/go.mod
[2022-01-30T02:43:23.759Z] +++ b/go.mod
[2022-01-30T02:43:23.759Z] @@ -193,6 +193,8 @@ require (
[2022-01-30T02:43:23.759Z]  	kernel.org/pub/linux/libs/security/libcap/cap v1.2.57
[2022-01-30T02:43:23.759Z]  )
[2022-01-30T02:43:23.759Z]  
[2022-01-30T02:43:23.759Z] +require github.com/kush-elastic/bayeux v1.0.1
[2022-01-30T02:43:23.759Z] +
[2022-01-30T02:43:23.759Z]  require (
[2022-01-30T02:43:23.759Z]  	cloud.google.com/go v0.97.0 // indirect
[2022-01-30T02:43:23.759Z]  	code.cloudfoundry.org/gofileutils v0.0.0-20170111115228-4d0c80011a0f // indirect
[2022-01-30T02:43:23.759Z] @@ -250,7 +252,6 @@ require (
[2022-01-30T02:43:23.759Z]  	github.com/json-iterator/go v1.1.12 // indirect
[2022-01-30T02:43:23.759Z]  	github.com/karrick/godirwalk v1.15.6 // indirect
[2022-01-30T02:43:23.759Z]  	github.com/klauspost/compress v1.13.6 // indirect
[2022-01-30T02:43:23.759Z] -	github.com/kush-elastic/bayeux v1.0.1 // indirect
[2022-01-30T02:43:23.759Z]  	github.com/markbates/pkger v0.17.0 // indirect
[2022-01-30T02:43:23.759Z]  	github.com/mattn/go-isatty v0.0.12 // indirect
[2022-01-30T02:43:23.759Z]  	github.com/mattn/go-runewidth v0.0.9 // indirect
[2022-01-30T02:43:24.705Z] NOTICE.txt: needs update
[2022-01-30T02:43:24.705Z] go.mod: needs update
[2022-01-30T02:43:24.705Z] Makefile:123: recipe for target 'check-no-changes' failed
[2022-01-30T02:43:24.705Z] make[1]: *** [check-no-changes] Error 1
[2022-01-30T02:43:24.705Z] make[1]: Leaving directory '/var/lib/jenkins/workspace/Beats_beats_PR-30089/src/github.com/elastic/beats'
[2022-01-30T02:43:24.705Z] Makefile:108: recipe for target 'check-default' failed
[2022-01-30T02:43:24.705Z] make: *** [check-default] Error 2

You can try to achieve it with make check-default in the repo Beats root folder.

mergify · 2022-02-02T21:54:19Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b salesforce_cometd_input upstream/salesforce_cometd_input
git merge upstream/master
git push upstream salesforce_cometd_input

kush-elastic · 2022-04-29T10:28:07Z

/test

kush-elastic · 2022-04-29T11:58:33Z

/test

mergify · 2022-04-29T12:29:43Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b salesforce_cometd_input upstream/salesforce_cometd_input
git merge upstream/main
git push upstream salesforce_cometd_input

kush-elastic · 2022-04-29T15:19:16Z

/test

kush-elastic · 2022-04-29T16:15:05Z

/test

kush-elastic · 2022-04-29T17:14:27Z

/test

kush-elastic · 2022-04-30T00:42:24Z

/test

yug-rajani · 2022-04-30T02:52:51Z

/test

kush-elastic · 2022-04-30T07:03:40Z

/test

mergify · 2022-05-02T11:02:21Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b salesforce_cometd_input upstream/salesforce_cometd_input
git merge upstream/main
git push upstream salesforce_cometd_input

kush-elastic · 2022-05-02T13:03:42Z

/test

kush-elastic · 2022-05-02T13:57:21Z

/test

cmacknz · 2022-05-02T14:21:16Z

Hey, Can anyone help me with this E2E Tests, i don't understand why they are failing. How can I debug it?

This is a known flaky test: elastic/e2e-testing#2420. The full list is here: https://github.com/elastic/e2e-testing/issues

The E2E tests in general are not as reliable as we would like them to be. If you only have E2E test failures we should be able to merge this.

yug-rajani · 2022-05-02T15:52:04Z

This is a known flaky test: elastic/e2e-testing#2420. The full list is here: https://github.com/elastic/e2e-testing/issues

Thanks for passing links, @cmacknz!

There are only have E2E test failures, all the other checks are green, but we don't have the authority to merge it. Can you please help us ship it?

cmacknz · 2022-05-02T15:55:41Z

I'll let the current build complete and then merge assuming we only see unrelated E2E test failures.

yug-rajani · 2022-05-02T16:04:20Z

@cmacknz Sure, thank you!

yug-rajani · 2022-05-02T17:00:31Z

@cmacknz FYI: The current build is complete except the E2E tests which seem stuck. Could you please help us merge the PR?

…#30089) * Add authentication mechanism for cometd input for Salesforce connector * Add data collection mechanism for Salesforce cometd input * Add asciidoc for cometd input Co-authored-by: Kush Rana <[email protected]> Co-authored-by: yug-crest <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Kush Rana <[email protected]>

cmacknz · 2022-05-02T19:35:49Z

The tests for this are flaky:


[2022-05-02T19:14:52.442Z] === Failed

[2022-05-02T19:14:52.442Z] === FAIL: x-pack/filebeat/input/cometd TestMultiInput (unknown)

[2022-05-02T19:14:52.442Z] coverage: 83.9% of statements

[2022-05-02T19:14:52.442Z] panic: test timed out after 10m0s

[2022-05-02T19:14:52.442Z] 

[2022-05-02T19:14:52.442Z] goroutine 53 [running]:

[2022-05-02T19:14:52.442Z] testing.(*M).startAlarm.func1()

[2022-05-02T19:14:52.442Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1788 +0x8e

[2022-05-02T19:14:52.443Z] created by time.goFunc

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/time/sleep.go:180 +0x31

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 1 [chan receive]:

[2022-05-02T19:14:52.443Z] testing.(*T).Run(0xc00026b1e0, {0x123ba47, 0x9bdb73}, 0x12705d8)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1307 +0x375

[2022-05-02T19:14:52.443Z] testing.runTests.func1(0xc00040e000)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1598 +0x6e

[2022-05-02T19:14:52.443Z] testing.tRunner(0xc00026b1e0, 0xc00025fce0)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1259 +0x102

[2022-05-02T19:14:52.443Z] testing.runTests(0xc0002a5f80, {0x1a6ace0, 0xd, 0xd}, {0x9e47cd, 0x123bfbf, 0x1a7c480})

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1596 +0x43f

[2022-05-02T19:14:52.443Z] testing.(*M).Run(0xc0002a5f80)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1504 +0x51d

[2022-05-02T19:14:52.443Z] main.main()

[2022-05-02T19:14:52.443Z] 	_testmain.go:121 +0x1f5

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 5 [semacquire]:

[2022-05-02T19:14:52.443Z] sync.runtime_Semacquire(0x109db00)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/runtime/sema.go:56 +0x25

[2022-05-02T19:14:52.443Z] sync.(*WaitGroup).Wait(0xc000516160)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/sync/waitgroup.go:130 +0x71

[2022-05-02T19:14:52.443Z] github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.TestMultiInput(0x0)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input_test.go:275 +0xbd0

[2022-05-02T19:14:52.443Z] testing.tRunner(0xc000062ea0, 0x12705d8)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1259 +0x102

[2022-05-02T19:14:52.443Z] created by testing.(*T).Run

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/testing/testing.go:1306 +0x35a

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 97 [chan receive (nil chan)]:

[2022-05-02T19:14:52.443Z] github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput.func1()

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:120 +0x38

[2022-05-02T19:14:52.443Z] created by github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:119 +0x36b

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 75 [chan receive (nil chan)]:

[2022-05-02T19:14:52.443Z] github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput.func1()

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:120 +0x38

[2022-05-02T19:14:52.443Z] created by github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:119 +0x36b

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 117 [chan receive (nil chan)]:

[2022-05-02T19:14:52.443Z] github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput.func1()

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:120 +0x38

[2022-05-02T19:14:52.443Z] created by github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:119 +0x36b

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 116 [chan receive (nil chan)]:

[2022-05-02T19:14:52.443Z] github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput.func1()

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:120 +0x38

[2022-05-02T19:14:52.443Z] created by github.com/elastic/beats/v7/x-pack/filebeat/input/cometd.NewInput

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/src/github.com/elastic/beats/x-pack/filebeat/input/cometd/input.go:119 +0x36b

[2022-05-02T19:14:52.443Z] 

[2022-05-02T19:14:52.443Z] goroutine 6 [IO wait]:

[2022-05-02T19:14:52.443Z] internal/poll.runtime_pollWait(0x1ed59c95010, 0x72)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/runtime/netpoll.go:303 +0x85

[2022-05-02T19:14:52.443Z] internal/poll.(*pollDesc).wait(0xc0000802e0, 0x95dd14, 0x0)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/internal/poll/fd_poll_runtime.go:84 +0x32

[2022-05-02T19:14:52.443Z] internal/poll.execIO(0xc00050c018, 0xc0003b7bf0)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/internal/poll/fd_windows.go:175 +0xe5

[2022-05-02T19:14:52.443Z] internal/poll.(*FD).acceptOne(0xc00050c000, 0x204, {0xc0005241e0, 0x9d285f, 0x0}, 0x0)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/internal/poll/fd_windows.go:810 +0x6d

[2022-05-02T19:14:52.443Z] internal/poll.(*FD).Accept(0xc00050c000, 0xc0003b7dc8)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/internal/poll/fd_windows.go:844 +0x1d6

[2022-05-02T19:14:52.443Z] net.(*netFD).accept(0xc00050c000)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/fd_windows.go:139 +0x65

[2022-05-02T19:14:52.443Z] net.(*TCPListener).accept(0xc000004060)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/tcpsock_posix.go:140 +0x28

[2022-05-02T19:14:52.443Z] net.(*TCPListener).Accept(0xc000004060)

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/tcpsock.go:262 +0x3d

[2022-05-02T19:14:52.443Z] net/http.(*Server).Serve(0xc00050e000, {0x134ea88, 0xc000004060})

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/http/server.go:3002 +0x394

[2022-05-02T19:14:52.443Z] net/http/httptest.(*Server).goServe.func1()

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/http/httptest/server.go:308 +0x6a

[2022-05-02T19:14:52.443Z] created by net/http/httptest.(*Server).goServe

[2022-05-02T19:14:52.443Z] 	C:/Users/jenkins/workspace/main-402-bba2b221-58ef-4155-8c44-a5797ae8e22a/.gvm/versions/go1.17.9.windows.amd64/src/net/http/httptest/server.go:306 +0x6f

From the first build after merging into main: https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats%2Fmain/detail/main/402/pipeline/

…lastic#30089)" This reverts commit 7ad5703.

…30089)" (#31485) This reverts commit 7ad5703.

cmacknz · 2022-05-02T19:39:40Z

I'm just going to revert the merge to main while a fix for the test timeout is above is found, rather than leave main in an unstable state.

You will need to open a new pull request bringing back the change and applying the needed fix. You can undo my revert by reverting it. git revert fa35c413d3 should do it.

* Add authentication mechanism for cometd input for Salesforce connector * Add data collection mechanism for Salesforce cometd input * Add asciidoc for cometd input Co-authored-by: Kush Rana <[email protected]> Co-authored-by: yug-crest <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Kush Rana <[email protected]>

…30089)" (#31485) This reverts commit 7ad5703.

kush-elastic and others added 8 commits November 26, 2021 12:45

Add authentication mechanism for cometd input for Salesforce connector

199e27f

update based on comments: clear empty line and add error.Errorf with …

0067633

…context

Add data collection mechanism for Salesforce cometd input

321463b

Merge branch 'salesforce_observability_connector' of https://github.c…

9a877c2

…om/kush-elastic/beats into salesforce_cometd_input

Update the approach of the channel

32a1790

Add asciidoc for cometd input

3855505

Resolve review comments

6e585ad

Update cometd input to import forked dependency

d67702d

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2022

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 28, 2022

yug-rajani requested review from mtojek, andresrc and marc-gr January 28, 2022 13:03

yug-rajani self-assigned this Jan 28, 2022

Temorarily remove changelog entry

8a24338

Run mage check and update

ab2a42f

yug-crest mentioned this pull request Jan 28, 2022

Add cometd input for Salesforce connector kush-elastic/beats#1

Closed

6 tasks

Update go.mod and go.sum

958c51c

Update go.mod and NOTICE.txt

7ff87d4

yug-rajani added 3 commits March 16, 2022 12:05

Fetch upstream and resolve merge conflicts

b673e08

Make changes with respect to ownership transfer

c658cd8

Update go.mod and go.sum

c05d8ba

resolve comman config errors

f13db12

Merge branch 'main' into salesforce_cometd_input

a4a02c4

Merge branch 'main' into salesforce_cometd_input

eac0644

cmacknz merged commit 7ad5703 into elastic:main May 2, 2022

cmacknz added a commit to cmacknz/beats that referenced this pull request May 2, 2022

Revert "[Filebeat][CometD] Add CometD input for Salesforce connector (e…

8590d5e

…lastic#30089)" This reverts commit 7ad5703.

cmacknz mentioned this pull request May 2, 2022

Revert "[Filebeat][CometD] Add CometD input for Salesforce connector … #31485

Merged

cmacknz added a commit that referenced this pull request May 2, 2022

Revert "[Filebeat][CometD] Add CometD input for Salesforce connector (#…

fa35c41

…30089)" (#31485) This reverts commit 7ad5703.

mtojek mentioned this pull request May 6, 2022

[Filebeat][CometD] Add CometD input for Salesforce connector #31492

Merged

6 tasks

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

Revert "[Filebeat][CometD] Add CometD input for Salesforce connector (#…

5123439

…30089)" (#31485) This reverts commit 7ad5703.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Filebeat][CometD] Add CometD input for Salesforce connector #30089

[Filebeat][CometD] Add CometD input for Salesforce connector #30089

yug-rajani commented Jan 28, 2022 •

edited by kush-elastic

Loading

mergify bot commented Jan 28, 2022

mergify bot commented Jan 28, 2022

yug-rajani commented Jan 28, 2022

elasticmachine commented Jan 28, 2022 •

edited by jenkins-beats-ci bot

Loading

Build stats

yug-rajani commented Jan 28, 2022

yug-rajani commented Jan 31, 2022

mtojek commented Feb 1, 2022

mergify bot commented Feb 2, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

mergify bot commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 30, 2022

yug-rajani commented Apr 30, 2022

kush-elastic commented Apr 30, 2022

mergify bot commented May 2, 2022

kush-elastic commented May 2, 2022

kush-elastic commented May 2, 2022

cmacknz commented May 2, 2022

yug-rajani commented May 2, 2022

cmacknz commented May 2, 2022

yug-rajani commented May 2, 2022

yug-rajani commented May 2, 2022

cmacknz commented May 2, 2022

cmacknz commented May 2, 2022

[Filebeat][CometD] Add CometD input for Salesforce connector #30089

[Filebeat][CometD] Add CometD input for Salesforce connector #30089

Conversation

yug-rajani commented Jan 28, 2022 • edited by kush-elastic Loading

What does this PR do?

Why is it important?

Checklist

mergify bot commented Jan 28, 2022

mergify bot commented Jan 28, 2022

yug-rajani commented Jan 28, 2022

elasticmachine commented Jan 28, 2022 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

yug-rajani commented Jan 28, 2022

yug-rajani commented Jan 31, 2022

mtojek commented Feb 1, 2022

mergify bot commented Feb 2, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

mergify bot commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 29, 2022

kush-elastic commented Apr 30, 2022

yug-rajani commented Apr 30, 2022

kush-elastic commented Apr 30, 2022

mergify bot commented May 2, 2022

kush-elastic commented May 2, 2022

kush-elastic commented May 2, 2022

cmacknz commented May 2, 2022

yug-rajani commented May 2, 2022

cmacknz commented May 2, 2022

yug-rajani commented May 2, 2022

yug-rajani commented May 2, 2022

cmacknz commented May 2, 2022

cmacknz commented May 2, 2022

yug-rajani commented Jan 28, 2022 •

edited by kush-elastic

Loading

elasticmachine commented Jan 28, 2022 •

edited by jenkins-beats-ci bot

Loading