-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs about hints and templates autodiscovery priority #30343
Conversation
Signed-off-by: chrismark <[email protected]>
This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
NOTE: |
@@ -100,6 +100,33 @@ Define an ingest pipeline ID to be added to the {beatname_uc} input/module confi | |||
co.elastic.logs/pipeline: custom-pipeline | |||
----- | |||
|
|||
When hints are used along with templates, then hints will be evaluated only in case | |||
there is no template's condition that resolve to true. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no template's condition that resolve to true. For example: | |
there is no template's condition that resolves to true. For example: |
should here maybe be added clarification if this is evaluated per container basis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this docs section we refer in general in docker+kubernetes autodiscover hence I would avoid mixing the concept of event based evaluation per container/pod for simplicity. In addition the way that autodiscover works is more or less described on the first paragraph of this page.
----- | ||
|
||
In this example first the condition `kubernetes.annotations.prometheus.io/scrape: "true"` | ||
is evaluated and if not matched the hints will be processed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metricbeat
doesn't have hints.default_config
, that is why it is omitted here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap. See
Registry: mb.Registry, |
DefaultConfig: defaultCfg, |
Signed-off-by: chrismark <[email protected]>
(cherry picked from commit 5961a2d)
…30429) (cherry picked from commit 5961a2d) Co-authored-by: Chris Mark <[email protected]>
…nd-k8s-env * upstream/main: fix typos and improve sentences (elastic#30432) Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (elastic#30440) {,x-pack/}auditbeat: replace uses of github.com/pkg/errors with stdlib equivalents (elastic#30321) Spelling fix (elastic#30439) packetbeat/beater: make sure Npcap installation runs before interfaces are needed in all cases (elastic#30438) Add BC about Homebrew no longer being available in 8.0 (elastic#30419) Install gawk as a replacement for mawk in Docker containers. (elastic#30452) Clean up python-related system tests (elastic#30415) Fix TestNewModuleRegistry flakiness (elastic#30453) [Filebeat] [auditd]: Support EXECVE events with truncated argument list (elastic#30382) Set `log.offset` to the start of the reported line in filestream (elastic#30445) clarify SelectedPackageTypes meaning and improve its usage (elastic#30142) [elasticsearch module] serialize shards properties (elastic#30408) Add docs about hints and templates autodiscovery priority (elastic#30343)
What does this PR do?
Adds documentation to state that it's possible to use autodiscover templating + hints based autodiscover together in a single Filebeat (and others) configuration.
Closes #26397